Commit 6830391
authored
feat(scouts): filter the fleet list by creator (#3292)
## Problem
The scouts fleet list shows every scout on the project. On a shared project with a large fleet (canonical scouts plus many teammates' custom ones), there's no way to narrow the list to the scouts a given person authored — most commonly your own.
## Changes
- Adds a **Created by** picker next to **Hide disabled** in the fleet list — "Any user" plus the fleet's distinct authors, with the current user pinned first (and always offered, so "just mine" is one click). Same filter shape as the cloud skills list's Created-by member filter.
- The configs endpoint carries no creator, so authorship is joined client-side from the backing `signals-scout-*` skills (`listLlmSkills` gained a `category` option; the fleet fetches `?category=scout` once). Canonical seeds carry no `created_by`, so they never match a person. As on the cloud skills list, "creator" means the latest version's author.
- Splits the fleet list into a pure `ScoutsFleetListView` (data via props) with Storybook stories for the default fleet, filtered-to-you, filtered-empty, and skills-API-gated states; the picker hides entirely when authorship is unknowable.
- New pure helpers in core (`buildScoutCreatorIndex`, `listScoutCreatorOptions`, `scoutCreatorKey`) with unit tests, and a `filter_created_by` scout analytics action.
The picker, open (Storybook, fixture data):
<img src="https://raw.githubusercontent.com/PostHog/code/37382bf9493edeb93b6499e70c61b8a5108293f5/.github/pr-assets/scouts-fleet-picker-open.png" width="900" alt="Scouts fleet list with the Created by picker open, showing Any user, the current user pinned first, and two other authors">
Filtered to the current user:
<img src="https://raw.githubusercontent.com/PostHog/code/37382bf9493edeb93b6499e70c61b8a5108293f5/.github/pr-assets/scouts-fleet-filtered.png" width="900" alt="Scouts fleet list filtered to the current user, showing only their scout">
(Screenshots were committed once for hosting and removed again in the next commit — the merged tree carries no binaries.)
**Why**: when viewing the list of scouts, you generally want to be able to select just the ones you (or a teammate) created.
## How did you test this?
- Unit tests for the creator helpers and option builder in `scoutPresentation.test.ts` (`pnpm --filter @posthog/core test` — 2172 passed).
- `pnpm turbo typecheck` for `shared`, `api-client`, `core`, and `ui`, plus `biome check` on the touched files — all clean.
- Rendered the new Storybook stories in the dev server and captured the screenshots above via headless Chromium (no page errors).
- Verified against the live backend serializers that `?category=scout` filtering and `created_by` on the skills list exist, and that canonical seeds have no author.
## Automatic notifications
- [ ] Publish to changelog?
- [ ] Alert Sales and Marketing teams?
---
*Created with [PostHog Code](https://posthog.com/code?ref=pr)*1 parent c9c5637 commit 6830391
8 files changed
Lines changed: 604 additions & 14 deletions
File tree
- packages
- api-client/src
- core/src/scouts
- ui/src/features/scouts
- components
- hooks
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4698 | 4698 | | |
4699 | 4699 | | |
4700 | 4700 | | |
| 4701 | + | |
| 4702 | + | |
4701 | 4703 | | |
4702 | | - | |
| 4704 | + | |
| 4705 | + | |
| 4706 | + | |
4703 | 4707 | | |
4704 | 4708 | | |
4705 | 4709 | | |
| 4710 | + | |
| 4711 | + | |
| 4712 | + | |
4706 | 4713 | | |
4707 | 4714 | | |
4708 | 4715 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| 14 | + | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
| 22 | + | |
| 23 | + | |
19 | 24 | | |
20 | 25 | | |
21 | 26 | | |
| |||
329 | 334 | | |
330 | 335 | | |
331 | 336 | | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
2 | 7 | | |
3 | 8 | | |
4 | 9 | | |
| |||
27 | 32 | | |
28 | 33 | | |
29 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
30 | 146 | | |
31 | 147 | | |
32 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
717 | 717 | | |
718 | 718 | | |
719 | 719 | | |
| 720 | + | |
720 | 721 | | |
721 | 722 | | |
722 | 723 | | |
| |||
775 | 776 | | |
776 | 777 | | |
777 | 778 | | |
| 779 | + | |
778 | 780 | | |
779 | 781 | | |
780 | 782 | | |
| |||
0 commit comments