Fix unstaging renamed files

Generated-By: PostHog Code
Task-Id: 496a1722-3291-4262-9b8b-1dccc2c7a652

Author: MattPua

packages/ui/src/features/task-detail/hooks/stageTogglePaths.test.ts

@@ -0,0 +1,24 @@
+import type { ChangedFile } from "@posthog/shared/domain-types";
+import { describe, expect, it } from "vitest";
+import { getStageTogglePaths } from "./stageTogglePaths";
+
+describe("getStageTogglePaths", () => {
+  it.each([
+    {
+      name: "uses the current path for a regular file",
+      file: { path: "current.ts", status: "modified" } satisfies ChangedFile,
+      expected: ["current.ts"],
+    },
+    {
+      name: "uses both paths for a renamed file",
+      file: {
+        path: "new.ts",
+        originalPath: "old.ts",
+        status: "renamed",
+      } satisfies ChangedFile,
+      expected: ["old.ts", "new.ts"],
+    },
+  ])("$name", ({ file, expected }) => {
+    expect(getStageTogglePaths(file)).toEqual(expected);
+  });
+});

packages/ui/src/features/task-detail/hooks/stageTogglePaths.ts

@@ -0,0 +1,9 @@
+import type { ChangedFile } from "@posthog/shared/domain-types";
+
+export function getStageTogglePaths(file: ChangedFile): string[] {
+  if (file.originalPath && file.originalPath !== file.path) {
+    return [file.originalPath, file.path];
+  }
+
+  return [file.path];
+}

packages/ui/src/features/task-detail/hooks/useStageToggle.ts

@@ -5,6 +5,7 @@ import { useCallback } from "react";
 import { logger } from "../../../shell/logger";
 import { invalidateGitWorkingTreeQueries } from "../../git-interaction/gitCacheKeys";
 import { updateGitCacheFromSnapshot } from "../../git-interaction/utils/updateGitCache";
+import { getStageTogglePaths } from "./stageTogglePaths";
 
 const log = logger.scope("use-stage-toggle");
 
@@ -21,7 +22,7 @@ export function useStageToggle(repoPath: string | undefined) {
       try {
         const result = await endpoint.mutateAsync({
           directoryPath: repoPath,
-          paths: [file.originalPath ?? file.path],
+          paths: getStageTogglePaths(file),
         });
         updateGitCacheFromSnapshot(queryClient, repoPath, result);
         invalidateGitWorkingTreeQueries(repoPath);