refactor(agent): rename codex mode resolver

Generated-By: PostHog Code

Task-Id: 1f1fe07c-6384-4d1e-8ab9-bad3700caa2e

Author: richardsolomou

packages/agent/src/adapters/codex-app-server/session-config.test.ts

@@ -6,7 +6,7 @@ import {
   collaborationModeFor,
   DEFAULT_EFFORTS,
   modeApprovalPolicy,
-  resolveInitialMode,
+  resolveCodexMode,
   SessionConfigState,
   sandboxPolicyFor,
 } from "./session-config";
@@ -108,16 +108,16 @@ describe("collaborationModeFor", () => {
   });
 });
 
-describe("resolveInitialMode", () => {
+describe("resolveCodexMode", () => {
   it.each([
     ["read-only", "read-only"],
     ["auto", "auto"],
     ["full-access", "full-access"],
     ["bypassPermissions", "full-access"],
     ["default", "auto"],
     [undefined, "auto"],
-  ])("maps initial permission mode %s to %s", (mode, expected) => {
-    expect(resolveInitialMode(mode)).toBe(expected);
+  ])("maps host mode %s to codex mode %s", (mode, expected) => {
+    expect(resolveCodexMode(mode)).toBe(expected);
   });
 });
 

packages/agent/src/adapters/codex-app-server/session-config.ts

@@ -126,16 +126,13 @@ export function collaborationModeFor(
 }
 
 /**
- * Resolve the host's initial `_meta.permissionMode` to a codex mode. A recognized
- * mode is honored; Claude's bypass mode maps to Codex full access. Other unknown
- * modes fall back to default.
+ * Resolve a host permission mode or live picker value to a codex mode. A
+ * recognized mode is honored; Claude's bypass mode maps to Codex full access.
+ * Other unknown modes fall back to default.
  */
-export function resolveInitialMode(permissionMode: string | undefined): string {
-  if (!permissionMode) return DEFAULT_MODE;
-  return resolveCloudInitialPermissionMode(
-    "codex",
-    permissionMode as ExecutionMode,
-  );
+export function resolveCodexMode(mode: string | undefined): string {
+  if (!mode) return DEFAULT_MODE;
+  return resolveCloudInitialPermissionMode("codex", mode as ExecutionMode);
 }
 
 /** Codex's standard reasoning efforts; used when model/list doesn't expose them. */
@@ -254,7 +251,7 @@ export class SessionConfigState {
 
   /** Apply the host's initial approval mode (from `_meta.permissionMode`). */
   setInitialMode(permissionMode: string | undefined): void {
-    this._mode = resolveInitialMode(permissionMode);
+    this._mode = resolveCodexMode(permissionMode);
     this.rebuild();
   }
 
@@ -268,7 +265,7 @@ export class SessionConfigState {
       if (configId === "model") this._model = value;
       else if (configId === "effort") this._effort = value;
       else if (configId === "mode") {
-        this._mode = resolveInitialMode(value);
+        this._mode = resolveCodexMode(value);
         modeChanged = true;
       }
     }