test(core): parameterise resolveRepositoryPickerList cases

Review feedback: the five cases share a single call-and-compare shape,
so express them as an it.each table per the repo's testing convention.

Generated-By: PostHog Code
Task-Id: 432c825c-dfe4-4b86-a3a0-c3217911b357

Author: fercgomes

packages/core/src/integrations/repositories.test.ts

@@ -8,6 +8,8 @@ import {
   isRepoInIntegration,
   normalizeRepoKey,
   type RepositoryCacheAction,
+  type RepositoryPickerList,
+  type RepositoryPickerListInputs,
   type RepositoryQueryResult,
   resolveEffectiveUserRepositoryMap,
   resolveRepositoryPickerList,
@@ -316,70 +318,69 @@ describe("resolveRepositoryPickerList", () => {
   const allRepositories = ["a/x", "a/y"];
   const pickerRepositories = ["a/x"];
 
-  it("shows the full list while the picker is closed", () => {
-    const result = resolveRepositoryPickerList({
-      pickerOpen: false,
-      pickerPending: true,
-      searchActive: false,
-      pickerRepositories,
-      allRepositories,
-    });
-    expect(result).toEqual({
-      repositories: allRepositories,
-      pickerLoading: false,
-    });
-  });
-
-  it("falls back to the full list while the first picker page loads", () => {
-    const result = resolveRepositoryPickerList({
-      pickerOpen: true,
-      pickerPending: true,
-      searchActive: false,
-      pickerRepositories: [],
-      allRepositories,
-    });
-    expect(result).toEqual({
-      repositories: allRepositories,
-      pickerLoading: false,
-    });
-  });
-
-  it("shows the loading picker list while a search is pending", () => {
-    const result = resolveRepositoryPickerList({
-      pickerOpen: true,
-      pickerPending: true,
-      searchActive: true,
-      pickerRepositories,
-      allRepositories,
-    });
-    expect(result).toEqual({
-      repositories: pickerRepositories,
-      pickerLoading: true,
-    });
-  });
-
-  it("keeps the loading state when there is no full list to fall back to", () => {
-    const result = resolveRepositoryPickerList({
-      pickerOpen: true,
-      pickerPending: true,
-      searchActive: false,
-      pickerRepositories: [],
-      allRepositories: [],
-    });
-    expect(result).toEqual({ repositories: [], pickerLoading: true });
-  });
+  const cases: Array<{
+    name: string;
+    inputs: RepositoryPickerListInputs;
+    expected: RepositoryPickerList;
+  }> = [
+    {
+      name: "shows the full list while the picker is closed",
+      inputs: {
+        pickerOpen: false,
+        pickerPending: true,
+        searchActive: false,
+        pickerRepositories,
+        allRepositories,
+      },
+      expected: { repositories: allRepositories, pickerLoading: false },
+    },
+    {
+      name: "falls back to the full list while the first picker page loads",
+      inputs: {
+        pickerOpen: true,
+        pickerPending: true,
+        searchActive: false,
+        pickerRepositories: [],
+        allRepositories,
+      },
+      expected: { repositories: allRepositories, pickerLoading: false },
+    },
+    {
+      name: "shows the loading picker list while a search is pending",
+      inputs: {
+        pickerOpen: true,
+        pickerPending: true,
+        searchActive: true,
+        pickerRepositories,
+        allRepositories,
+      },
+      expected: { repositories: pickerRepositories, pickerLoading: true },
+    },
+    {
+      name: "keeps the loading state when there is no full list to fall back to",
+      inputs: {
+        pickerOpen: true,
+        pickerPending: true,
+        searchActive: false,
+        pickerRepositories: [],
+        allRepositories: [],
+      },
+      expected: { repositories: [], pickerLoading: true },
+    },
+    {
+      name: "shows the picker list once it settles",
+      inputs: {
+        pickerOpen: true,
+        pickerPending: false,
+        searchActive: false,
+        pickerRepositories,
+        allRepositories,
+      },
+      expected: { repositories: pickerRepositories, pickerLoading: false },
+    },
+  ];
 
-  it("shows the picker list once it settles", () => {
-    const result = resolveRepositoryPickerList({
-      pickerOpen: true,
-      pickerPending: false,
-      searchActive: false,
-      pickerRepositories,
-      allRepositories,
-    });
-    expect(result).toEqual({
-      repositories: pickerRepositories,
-      pickerLoading: false,
-    });
+  it.each(cases)("$name", ({ inputs, expected }) => {
+    expect(resolveRepositoryPickerList(inputs)).toEqual(expected);
   });
 });