fix(sidebar): address PR review comments

MattPua · MattPua · commit 98b2ff0b6998 · 2026-07-03T13:36:59.000-04:00
- Add toast on folder context menu action failure
- Remove misused aria-busy from button element

Generated-By: PostHog Code
Task-Id: c24a31b4-54a1-4f5f-8092-ac1ee33ace07
diff --git a/packages/ui/src/features/sidebar/components/SidebarMenu.tsx b/packages/ui/src/features/sidebar/components/SidebarMenu.tsx
@@ -247,6 +247,7 @@ function SidebarMenuComponent() {
         }
       } catch (error) {
         log.error("Failed to show folder context menu", error);
+        toast.error("Couldn't perform folder action");
       }
     },
     [folders, removeFolder, hostClient, openExternalApp],
diff --git a/packages/ui/src/features/sidebar/components/TasksHeader.tsx b/packages/ui/src/features/sidebar/components/TasksHeader.tsx
@@ -52,7 +52,6 @@ function AddFolderButton() {
         size="icon-sm"
         onClick={handleClick}
         disabled={isOpening}
-        aria-busy={isOpening}
       >
         <FolderPlus size={14} />
       </Button>

Original file line number	Diff line number	Diff line change
`@@ -247,6 +247,7 @@ function SidebarMenuComponent() {`
`247`	`247`	`}`
`248`	`248`	`} catch (error) {`
`249`	`249`	`log.error("Failed to show folder context menu", error);`
	`250`	`+ toast.error("Couldn't perform folder action");`
`250`	`251`	`}`
`251`	`252`	`},`
`252`	`253`	`[folders, removeFolder, hostClient, openExternalApp],`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ function AddFolderButton() {`
`52`	`52`	`size="icon-sm"`
`53`	`53`	`onClick={handleClick}`
`54`	`54`	`disabled={isOpening}`
`55`		`- aria-busy={isOpening}`
`56`	`55`	`>`
`57`	`56`	`<FolderPlus size={14} />`
`58`	`57`	`</Button>`