Skip to content

Commit a140860

Browse files
committed
fix(code-review): hide filters with comments
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
1 parent 3e75d53 commit a140860

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

packages/ui/src/features/code-review/components/DiffSettingsMenu.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@ export function DiffSettingsMenu({
4343
const toggleShowReviewComments = useDiffViewerStore(
4444
(s) => s.toggleShowReviewComments,
4545
);
46+
const handleToggleReviewComments = () => {
47+
if (showReviewComments && commentFilter !== "none") {
48+
onCommentFilterChange?.("none");
49+
}
50+
toggleShowReviewComments();
51+
};
4652

4753
return (
4854
<DropdownMenu>
@@ -78,10 +84,10 @@ export function DiffSettingsMenu({
7884
{hideWhitespaceChanges ? "Show whitespace" : "Hide whitespace"}
7985
</DropdownMenuItem>
8086
<DropdownMenuSeparator />
81-
<DropdownMenuItem onClick={toggleShowReviewComments}>
87+
<DropdownMenuItem onClick={handleToggleReviewComments}>
8288
{showReviewComments ? "Hide review comments" : "Show review comments"}
8389
</DropdownMenuItem>
84-
{onCommentFilterChange && (
90+
{showReviewComments && onCommentFilterChange && (
8591
<DropdownMenuSub>
8692
<DropdownMenuSubTrigger>
8793
Comment filter

0 commit comments

Comments
 (0)