refactor(billing): drop the seat-retirement memo; keep only readable 410 copy

Seats are gone entirely by cutover and the whole seat surface gets deleted
after it, so special handling isn't worth carrying: SeatService goes back to
main unchanged (auto-provision already fails soft on any create error), and
the 410 keeps only a typed error plus readable copy in classifySeatError for
the seat-era UI still visible until the flag flips.

Generated-By: PostHog Code
Task-Id: 1039ea23-9930-44e2-9888-b05cf8b129ec

Author: adboio

packages/core/src/billing/seatErrors.ts

@@ -3,20 +3,15 @@ export interface ClassifiedSeatError {
   redirectUrl: string | null;
 }
 
-/**
- * The seat API's 410 Gone: PostHog Code seats are retired in favor of
- * usage-based billing. Name-based so it survives the SeatClient seam.
- */
-export function isSeatProductRetiredError(error: unknown): boolean {
-  return error instanceof Error && error.name === "SeatProductRetiredError";
-}
-
 export function classifySeatError(error: unknown): ClassifiedSeatError {
   if (!(error instanceof Error)) {
     return { error: "An unexpected error occurred", redirectUrl: null };
   }
 
-  if (isSeatProductRetiredError(error)) {
+  // The seat API's 410 Gone: seats are retired in favor of usage-based
+  // billing. Only reachable from the seat-era UI, which goes away with the
+  // cutover — no handling beyond readable copy.
+  if (error.name === "SeatProductRetiredError") {
     return {
       error:
         "PostHog Code seat plans have been retired — usage is now billed to your organization.",

packages/core/src/billing/seatService.test.ts

@@ -300,36 +300,6 @@ describe("seat product retired (410 Gone)", () => {
     expect(result.error).toBeNull();
   });
 
-  it("stops re-attempting provisioning once the product is known retired", async () => {
-    const createSeat = vi.fn().mockRejectedValue(new SeatProductRetiredError());
-    const client = makeClient({ createSeat });
-    const service = new SeatService(client, logger);
-
-    await service.fetchSeat({ autoProvision: true });
-    createSeat.mockClear();
-    await service.fetchSeat({ autoProvision: true });
-
-    expect(createSeat).not.toHaveBeenCalled();
-  });
-
-  it("still re-fetches the seat after a non-retirement provisioning failure", async () => {
-    const seat = makeSeat();
-    const getMySeat = vi
-      .fn()
-      .mockResolvedValueOnce(null)
-      .mockResolvedValueOnce(null)
-      .mockResolvedValue(seat);
-    const client = makeClient({
-      getMySeat,
-      createSeat: vi.fn().mockRejectedValue(new Error("conflict")),
-    });
-    const result = await new SeatService(client, logger).fetchSeat({
-      autoProvision: true,
-    });
-    expect(result.error).toBeNull();
-    expect(result.seat).toEqual(seat);
-  });
-
   it("surfaces retirement as a clear error on an explicit upgrade", async () => {
     const client = makeClient({
       createSeat: vi.fn().mockRejectedValue(new SeatProductRetiredError()),

packages/core/src/billing/seatService.ts

@@ -2,11 +2,7 @@ import { ROOT_LOGGER, type RootLogger } from "@posthog/di/logger";
 import { PLAN_FREE, PLAN_PRO, type SeatData } from "@posthog/shared";
 import { inject, injectable } from "inversify";
 import { SEAT_CLIENT, type SeatClient, type SeatLogger } from "./identifiers";
-import {
-  type ClassifiedSeatError,
-  classifySeatError,
-  isSeatProductRetiredError,
-} from "./seatErrors";
+import { type ClassifiedSeatError, classifySeatError } from "./seatErrors";
 
 export interface SeatOperationResult {
   seat: SeatData | null;
@@ -47,11 +43,6 @@ function fail(classified: ClassifiedSeatError): SeatOperationResult {
 export class SeatService {
   private readonly logger: SeatLogger;
 
-  // The seat API 410s creation/upgrades/reactivation once seats are retired
-  // (usage-based billing). Remembered so auth/onboarding fetches stop
-  // re-attempting a provision that can never succeed.
-  private seatProductRetired = false;
-
   constructor(
     @inject(SEAT_CLIENT) private readonly client: SeatClient,
     @inject(ROOT_LOGGER) logger: RootLogger,
@@ -64,18 +55,13 @@ export class SeatService {
     autoProvision: boolean;
   }): Promise<SeatData | null> {
     let seat = await this.client.getMySeat({ best: options.best });
-    if (!seat && options.autoProvision && !this.seatProductRetired) {
+    if (!seat && options.autoProvision) {
       this.logger.info("No seat found, auto-provisioning free plan", {
         best: options.best,
       });
       try {
         seat = await this.client.createSeat(PLAN_FREE);
-      } catch (error) {
-        if (isSeatProductRetiredError(error)) {
-          this.seatProductRetired = true;
-          this.logger.info("Seat product retired; skipping auto-provision");
-          return null;
-        }
+      } catch {
         this.logger.info("Auto-provision failed, re-fetching seat");
         seat = await this.client.getMySeat({ best: options.best });
       }
@@ -132,7 +118,6 @@ export class SeatService {
       this.client.invalidatePlanCache();
       return ok(seat, null, true);
     } catch (error) {
-      if (isSeatProductRetiredError(error)) this.seatProductRetired = true;
       this.logger.error("provisionFreeSeat failed", error);
       return fail(classifySeatError(error));
     }
@@ -158,7 +143,6 @@ export class SeatService {
       this.client.invalidatePlanCache();
       return ok(seat, seat);
     } catch (error) {
-      if (isSeatProductRetiredError(error)) this.seatProductRetired = true;
       return fail(classifySeatError(error));
     }
   }
@@ -184,7 +168,6 @@ export class SeatService {
       this.client.invalidatePlanCache();
       return ok(seat, seat);
     } catch (error) {
-      if (isSeatProductRetiredError(error)) this.seatProductRetired = true;
       return fail(classifySeatError(error));
     }
   }