fix(code): avoid redundant zoom restoration

Generated-By: PostHog Code
Task-Id: 33078092-6d41-45e8-8375-157f66bcea43

Author: richardsolomou

apps/code/src/main/zoom.test.ts

@@ -28,6 +28,10 @@ class FakeWebContents extends EventEmitter {
     return this.destroyed;
   }
 
+  public getZoomLevel(): number {
+    return this.zoomLevel;
+  }
+
   public setZoomLevel(level: number): void {
     this.setZoomLevelCalls.push(level);
     this.zoomLevel = level;
@@ -98,7 +102,6 @@ describe("window zoom", () => {
 
     window.webContents.emit("zoom-changed", { preventDefault: vi.fn() }, "in");
     vi.runAllTimers();
-    vi.advanceTimersByTime(5 * 60 * 1000);
     window.webContents.zoomLevel = 0;
 
     window.emit("resize");
@@ -166,17 +169,29 @@ describe("window zoom", () => {
     },
   );
 
-  it("debounces repeated resize restorations", () => {
+  it("skips redundant restoration during a resize storm", () => {
     const window = createWindow();
     setupWindowZoom(window);
-    window.webContents.zoomLevel = 0;
+    window.webContents.zoomLevel = 0.5;
 
     window.emit("resize");
+    vi.runAllTimers();
+    vi.advanceTimersByTime(16);
     window.emit("resize");
-    window.emit("resized");
     vi.runAllTimers();
+    const callsBeforeReset = [...window.webContents.setZoomLevelCalls];
 
-    expect(window.webContents.setZoomLevelCalls).toEqual([0.5]);
+    window.webContents.zoomLevel = 0;
+    window.emit("resize");
+    vi.runAllTimers();
+
+    expect({
+      callsBeforeReset,
+      callsAfterReset: window.webContents.setZoomLevelCalls,
+    }).toEqual({
+      callsBeforeReset: [],
+      callsAfterReset: [0.5],
+    });
   });
 
   it("ignores queued zoom work after the window is destroyed", () => {

apps/code/src/main/zoom.ts

@@ -6,6 +6,7 @@ const ZOOM_MIN = -3;
 const ZOOM_MAX = 3;
 
 interface ZoomWebContents {
+  getZoomLevel(): number;
   isDestroyed(): boolean;
   on(event: "did-finish-load", listener: () => void): void;
   on(
@@ -86,7 +87,10 @@ export function adjustWindowZoom(
 export function restoreWindowZoom(window: ZoomWindow): void {
   runAfterWheelZoom(window, () => {
     if (window.webContents.isDestroyed()) return;
-    window.webContents.setZoomLevel(getCurrentZoomLevel(window));
+    const zoomLevel = getCurrentZoomLevel(window);
+    if (window.webContents.getZoomLevel() !== zoomLevel) {
+      window.webContents.setZoomLevel(zoomLevel);
+    }
   });
 }