hardcode public app ID

Author: gantoine

.env.example

@@ -10,7 +10,3 @@ APPLE_CODESIGN_KEYCHAIN_PASSWORD="xxx"
 VITE_POSTHOG_API_KEY=xxx
 VITE_POSTHOG_API_HOST=xxx
 VITE_POSTHOG_UI_HOST=xxx
-
-# Discord Rich Presence. Upload Rich Presence art assets named
-# "posthog_logo", "agent_running", and "posthog_idle" in the Discord app.
-VITE_DISCORD_CLIENT_ID=

apps/code/src/main/services/discord-presence/constants.ts

@@ -1,14 +1,18 @@
 /**
  * Discord Rich Presence configuration.
  *
- * The client id identifies the Discord Application whose name and uploaded
+ * The client id is the public Discord Application ID whose name and uploaded
  * Rich Presence art (the `*_IMAGE_KEY` assets below) show up on a user's
- * profile. Register an application at https://discord.com/developers and wire
- * its id through `VITE_DISCORD_CLIENT_ID` (see `.env.example`). Until a real id
- * is configured the service stays dormant and never opens a socket.
+ * profile. It is a public identifier — only the application's client *secret*
+ * (unused by Rich Presence) is sensitive — so it ships in the build for every
+ * client. Register an application at https://discord.com/developers, upload the
+ * art assets, then drop its ID here.
  */
+// TODO: replace with the real PostHog Code Discord Application ID.
+const DISCORD_CLIENT_ID = "1511709200017920020";
+
 export function getDiscordClientId(): string {
-  return process.env.VITE_DISCORD_CLIENT_ID ?? "";
+  return DISCORD_CLIENT_ID;
 }
 
 /** Asset keys uploaded under the Discord app's Rich Presence → Art Assets. */

apps/code/src/main/services/discord-presence/service.ts

@@ -110,7 +110,7 @@ export class DiscordPresenceService extends TypedEventEmitter<DiscordPresenceSer
   private connect(): void {
     if (!this.clientId) {
       log.warn(
-        "VITE_DISCORD_CLIENT_ID is not configured; Discord Rich Presence will stay dormant",
+        "No Discord Application ID is set; Discord Rich Presence will stay dormant",
       );
       return;
     }

apps/code/src/renderer/features/settings/components/sections/DiscordSettings.tsx

@@ -104,7 +104,7 @@ export function DiscordSettings() {
           {!configured ? (
             <Text color="yellow" className="-mt-3 pb-3 text-[13px]">
               No Discord application is configured for this build, so nothing
-              will appear yet. Set VITE_DISCORD_CLIENT_ID to connect.
+              will appear yet.
             </Text>
           ) : (
             <Text

apps/code/vite.main.config.mts

@@ -626,9 +626,6 @@ export default defineConfig(({ mode }) => {
       "process.env.VITE_POSTHOG_ACCESS_TOKEN_OVERRIDE": JSON.stringify(
         env.VITE_POSTHOG_ACCESS_TOKEN_OVERRIDE || "",
       ),
-      "process.env.VITE_DISCORD_CLIENT_ID": JSON.stringify(
-        env.VITE_DISCORD_CLIENT_ID || "",
-      ),
       "process.env.SKILLS_ZIP_URL": JSON.stringify(SKILLS_ZIP_URL),
       "process.env.CONTEXT_MILL_ZIP_URL": JSON.stringify(CONTEXT_MILL_ZIP_URL),
       ...createForceDevModeDefine(),