fix(canvas): address thread feed review findings

Generated-By: PostHog Code
Task-Id: 87a79e23-20c4-440b-818b-28154924ffbc

Author: k11kirky

packages/core/src/canvas/channelFeed.test.ts

@@ -0,0 +1,28 @@
+import { describe, expect, it } from "vitest";
+import { taskFeedRunStatus } from "./channelFeed";
+
+describe("taskFeedRunStatus", () => {
+  it.each(["queued", "in_progress"] as const)(
+    "preserves a cloud %s status even when local session activity has settled",
+    (status) => {
+      expect(
+        taskFeedRunStatus({
+          status,
+          environment: "cloud",
+        }),
+      ).toBe(status);
+    },
+  );
+
+  it("hides an unreliable non-terminal local status", () => {
+    expect(
+      taskFeedRunStatus({ status: "queued", environment: "local" }),
+    ).toBeNull();
+  });
+
+  it("keeps a terminal local status", () => {
+    expect(
+      taskFeedRunStatus({ status: "completed", environment: "local" }),
+    ).toBe("completed");
+  });
+});

packages/core/src/canvas/channelFeed.ts

@@ -0,0 +1,23 @@
+import type { TaskRunStatus } from "@posthog/shared/domain-types";
+import { isTerminalStatus } from "@posthog/shared/domain-types";
+
+const PERMANENT_CHANNEL_FEED_FAILURES = new Set([401, 403, 404]);
+
+export function shouldPollChannelFeed(error: unknown): boolean {
+  if (!error || typeof error !== "object" || !("status" in error)) return true;
+  const status = (error as { status?: unknown }).status;
+  return (
+    typeof status !== "number" || !PERMANENT_CHANNEL_FEED_FAILURES.has(status)
+  );
+}
+
+export function taskFeedRunStatus({
+  status,
+  environment,
+}: {
+  status: TaskRunStatus | null | undefined;
+  environment: string | null | undefined;
+}): TaskRunStatus | null {
+  if (!status) return null;
+  return environment === "cloud" || isTerminalStatus(status) ? status : null;
+}

packages/ui/src/features/canvas/components/ChannelFeedView.tsx

@@ -4,6 +4,7 @@ import {
   GitBranchIcon,
   RobotIcon,
 } from "@phosphor-icons/react";
+import { taskFeedRunStatus } from "@posthog/core/canvas/channelFeed";
 import {
   Avatar,
   AvatarFallback,
@@ -37,7 +38,6 @@ import {
 } from "@posthog/quill";
 import { formatRelativeTimeShort, getLocalDayDiff } from "@posthog/shared";
 import type { Task, TaskRunStatus } from "@posthog/shared/domain-types";
-import { isTerminalStatus } from "@posthog/shared/domain-types";
 import { getUserInitials } from "@posthog/ui/features/auth/userInitials";
 import { TaskTabIcon } from "@posthog/ui/features/browser-tabs/TaskTabIcon";
 import { mentionChipClass } from "@posthog/ui/features/canvas/components/MentionText";
@@ -46,7 +46,6 @@ import { useChannelTaskData } from "@posthog/ui/features/canvas/hooks/useChannel
 import { useTaskThread } from "@posthog/ui/features/canvas/hooks/useTaskThread";
 import { shouldOpenTaskCardInline } from "@posthog/ui/features/canvas/taskCardNavigation";
 import { userDisplayName } from "@posthog/ui/features/canvas/utils/userDisplay";
-import { useSessionSelector } from "@posthog/ui/features/sessions/useSession";
 import {
   type SidebarPrState,
   useTaskPrStatus,
@@ -163,21 +162,14 @@ interface TaskStatusDisplay {
 // deliberate end state we should not soften with a PR.
 function useTaskStatusDisplay(task: Task): TaskStatusDisplay {
   const data = useChannelTaskData(task);
-  const agentSettledAfterRun = useSessionSelector(
-    task.id,
-    (session) =>
-      !!session &&
-      (session.events?.length ?? 0) > 0 &&
-      !session.isPromptPending &&
-      (session.pendingPermissions?.size ?? 0) === 0,
-  );
   const { prState } = useTaskPrStatus({
     id: task.id,
     cloudPrUrl: data?.cloudPrUrl ?? null,
     taskRunEnvironment: data?.taskRunEnvironment ?? null,
   });
   const status = data?.taskRunStatus ?? task.latest_run?.status;
   const environment = data?.taskRunEnvironment ?? task.latest_run?.environment;
+  const displayStatus = taskFeedRunStatus({ status, environment });
   // `prState` is resolved async from git/`gh` and is routinely null for cloud
   // tasks (the details fetch hasn't landed, or there's no cached row). But the
   // PR URL itself is a hard signal a PR exists — the card's "PR" link keys off
@@ -209,10 +201,8 @@ function useTaskStatusDisplay(task: Task): TaskStatusDisplay {
     base = null;
   } else if (!status) {
     base = <Badge>Draft</Badge>;
-  } else if (environment === "cloud" || isTerminalStatus(status)) {
-    const effectiveStatus =
-      agentSettledAfterRun && !isTerminalStatus(status) ? "completed" : status;
-    base = statusBadge(effectiveStatus);
+  } else if (displayStatus) {
+    base = statusBadge(displayStatus);
   } else {
     // Local, non-terminal: the run status is unreliable (the backend row stays
     // "queued" while the agent runs on the creator's machine), so we render no

packages/ui/src/features/canvas/components/ThreadPanel.test.tsx

@@ -1,6 +1,37 @@
+import type { ConversationItem } from "@posthog/ui/features/sessions/components/buildConversationItems";
 import { render, screen } from "@testing-library/react";
 import { describe, expect, it } from "vitest";
 import { AgentStatusLine, UserPromptRow } from "./ThreadPanel";
+import { agentTurns } from "./threadAgentTurns";
+
+describe("agentTurns", () => {
+  it("accumulates every text chunk in one agent turn", () => {
+    const items = [
+      {
+        type: "session_update",
+        id: "first",
+        timestamp: 10,
+        update: {
+          sessionUpdate: "agent_message_chunk",
+          content: { type: "text", text: "Hello" },
+        },
+      },
+      {
+        type: "session_update",
+        id: "second",
+        timestamp: 20,
+        update: {
+          sessionUpdate: "agent_message_chunk",
+          content: { type: "text", text: " there" },
+        },
+      },
+    ] as ConversationItem[];
+
+    expect(agentTurns(items)).toEqual([
+      { id: "first", text: "Hello there", timestamp: 10 },
+    ]);
+  });
+});
 
 describe("AgentStatusLine", () => {
   it("renders working status outside the conversation timeline", () => {