fix(stamphog): consume trusted PR reactions

Generated-By: PostHog Code
Task-Id: fa3ff167-712b-41c4-aa27-aa8ec1700f4e

Author: adboio

tools/pr-approval-agent/github.py

@@ -6,7 +6,6 @@
 """
 
 import json
-import re
 import subprocess
 from dataclasses import dataclass, field
 from pathlib import Path
@@ -54,8 +53,14 @@ def has_new_files(self) -> bool:
 
 
 _TRUSTED_ASSOCIATIONS = {"MEMBER", "OWNER", "COLLABORATOR"}
-_REVIEWHOG_BOT_LOGIN = "posthog[bot]"
-_REVIEWHOG_STATUS_RE = re.compile(r"<!--\s*reviewhog:status:[0-9a-f-]+\s*-->")
+TRUSTED_REACTOR_BOTS = {
+    "chatgpt-codex-connector[bot]",
+    "copilot-pull-request-reviewer[bot]",
+    "greptile-apps[bot]",
+    "hex-security-app[bot]",
+    "posthog[bot]",
+    "veria-ai[bot]",
+}
 
 
 def _normalize_reviews_for_prompt(reviews_raw: list[dict], head_sha: str) -> list[dict]:
@@ -89,24 +94,20 @@ def _normalize_reviews_for_prompt(reviews_raw: list[dict], head_sha: str) -> lis
     return normalized_reviews
 
 
-def _reviewhog_clean_reactions(comments_raw: list[dict]) -> list[dict]:
-    for comment in reversed(comments_raw):
-        user = comment.get("user") or {}
-        if user.get("login", "").lower() != _REVIEWHOG_BOT_LOGIN or user.get("type") != "Bot":
-            continue
-        body = comment.get("body") or ""
-        if "Found no issues worth raising, so no review was posted." not in body:
+def _normalize_pr_reactions(reactions_raw: list[dict], author: str) -> list[dict]:
+    normalized = []
+    for reaction in reactions_raw:
+        login = (reaction.get("user") or {}).get("login", "")
+        if login == author or login.lower() not in TRUSTED_REACTOR_BOTS:
             continue
-        if _REVIEWHOG_STATUS_RE.search(body) is None:
-            continue
-        return [
+        normalized.append(
             {
-                "user": "reviewhog[bot]",
-                "emoji": "👍",
-                "created_at": comment.get("updated_at") or comment.get("created_at"),
+                "user": login,
+                "emoji": {"+1": "👍", "-1": "👎", "eyes": "👀"}.get(reaction.get("content"), reaction.get("content")),
+                "created_at": reaction.get("created_at"),
             }
-        ]
-    return []
+        )
+    return normalized
 
 
 def _gh_api(endpoint: str, *, paginate: bool = False) -> dict | list:
@@ -282,12 +283,12 @@ def fetch_pr(pr_number: int, repo: str, repo_root: Path | None = None) -> PRData
     base_sha = pr["base"]["sha"]
     head_sha = pr["head"]["sha"]
     check_runs_resp = _gh_api(f"repos/{repo}/commits/{head_sha}/check-runs")
-    reviewhog_reactions: list[dict] = []
+    pr_reactions: list[dict] = []
     try:
-        discussion_raw = _gh_api(f"repos/{repo}/issues/{pr_number}/comments", paginate=True)
-        reviewhog_reactions = _reviewhog_clean_reactions(discussion_raw)
+        reactions_raw = _gh_api(f"repos/{repo}/issues/{pr_number}/reactions", paginate=True)
+        pr_reactions = _normalize_pr_reactions(reactions_raw, pr["user"]["login"])
     except Exception as exc:
-        print(f"warning: discussion fetch failed ({exc}); continuing without ReviewHog assurance")
+        print(f"warning: reaction fetch failed ({exc}); continuing without reaction context")
 
     git_root = repo_root or Path.cwd()
     ensure_commits(pr_number, head_sha, git_root)
@@ -310,7 +311,7 @@ def fetch_pr(pr_number: int, repo: str, repo_root: Path | None = None) -> PRData
         reviews=_normalize_reviews_for_prompt(reviews_raw, head_sha),
         review_comments=review_comments,
         check_runs=check_runs_resp.get("check_runs", []),
-        pr_reactions=reviewhog_reactions,
+        pr_reactions=pr_reactions,
     )
 
 

tools/pr-approval-agent/reviewer.py

@@ -174,9 +174,9 @@ def _validate_verdict(result: dict) -> dict:
       reviews as a concern and ESCALATE unless there's a strong,
       specific justification to APPROVE.
     - Bot comments with valid concerns that were ignored → ESCALATE
-    - ReviewHog's authenticated clean status appears as 👍 @reviewhog[bot]. Treat
-      it as the same mild positive signal as a clean Greptile or Hex reaction:
-      useful corroboration, but never sufficient by itself to approve.
+    - Trusted reviewer reactions are included. A 👍 is mild positive evidence and
+      a 👎 is mild negative evidence; neither is sufficient by itself. An 👀 means
+      a review is still in flight, so do not approve until it finishes.
 
     Tools: You have Read, Grep, and Glob (restricted to the repo directory).
     All PR metadata (comments, ownership) is in the prompt — do NOT fetch

tools/pr-approval-agent/test_github.py

@@ -2,7 +2,7 @@
 
 import pytest
 
-from github import _normalize_reviews_for_prompt, _reviewhog_clean_reactions
+from github import _normalize_pr_reactions, _normalize_reviews_for_prompt
 
 
 def test_normalize_reviews_marks_current_head_and_preserves_stale_reviews() -> None:
@@ -77,63 +77,43 @@ def test_normalize_reviews_filters_by_trust_source(
     assert len(normalized) == expected_count
 
 
-def test_reviewhog_clean_status_is_normalized_as_a_trusted_positive() -> None:
-    reactions = _reviewhog_clean_reactions(
+def test_normalize_pr_reactions_keeps_trusted_reviewer_bots() -> None:
+    reactions = _normalize_pr_reactions(
         [
             {
-                "user": {"login": "posthog[bot]", "type": "Bot"},
-                "body": (
-                    "Found no issues worth raising, so no review was posted.\n\n"
-                    "<!-- reviewhog:status:019f807c-68a6-7d18-b010-85409c5ed4ad -->"
-                ),
+                "user": {"login": "posthog[bot]"},
+                "content": "+1",
                 "created_at": "2026-07-20T17:04:26Z",
-                "updated_at": "2026-07-20T17:05:26Z",
             }
-        ]
+        ],
+        "author",
     )
 
     assert reactions == [
         {
-            "user": "reviewhog[bot]",
+            "user": "posthog[bot]",
             "emoji": "👍",
-            "created_at": "2026-07-20T17:05:26Z",
+            "created_at": "2026-07-20T17:04:26Z",
         }
     ]
 
 
-def _clean_reviewhog_body() -> str:
-    return (
-        "Found no issues worth raising, so no review was posted.\n\n"
-        "<!-- reviewhog:status:019f807c-68a6-7d18-b010-85409c5ed4ad -->"
-    )
-
-
 @pytest.mark.parametrize(
-    "login,user_type,body",
+    "login,author",
     [
-        pytest.param("posthog[bot]", "User", _clean_reviewhog_body(), id="not-app-bot"),
-        pytest.param("someone[bot]", "Bot", _clean_reviewhog_body(), id="wrong-bot"),
-        pytest.param(
-            "posthog[bot]", "Bot", "Found no issues worth raising, so no review was posted.", id="missing-marker"
-        ),
-        pytest.param(
-            "posthog[bot]",
-            "Bot",
-            "Found 1 should fix.\n<!-- reviewhog:status:019f807c-68a6-7d18-b010-85409c5ed4ad -->",
-            id="not-clean",
-        ),
+        pytest.param("someone[bot]", "author", id="untrusted-bot"),
+        pytest.param("posthog[bot]", "posthog[bot]", id="author-self-reaction"),
     ],
 )
-def test_reviewhog_clean_status_rejects_untrusted_or_non_clean_comments(
-    login: str, user_type: str, body: str
-) -> None:
-    reactions = _reviewhog_clean_reactions(
+def test_normalize_pr_reactions_rejects_untrusted_or_author_reactions(login: str, author: str) -> None:
+    reactions = _normalize_pr_reactions(
         [
             {
-                "user": {"login": login, "type": user_type},
-                "body": body,
+                "user": {"login": login},
+                "content": "+1",
             }
-        ]
+        ],
+        author,
     )
 
     assert reactions == []