test(discord-presence): parameterise buildActivity and assert truncation content

Collapse the per-scenario it blocks into a single it.each table, and make
the truncation case verify the prefix and trailing ellipsis are preserved
rather than only bounding the length.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: gantoine

apps/code/src/main/services/discord-presence/presence-format.test.ts

@@ -17,68 +17,118 @@ const activeIntent: PresenceIntent = {
   agentRunning: true,
 };
 
-describe("buildActivity", () => {
-  it("hides the task title and repo name by default (privacy-first)", () => {
-    const activity = buildActivity(activeIntent, baseOptions);
-    expect(activity.details).toBe("Working on a task");
-    expect(activity.state).toBe("agent running");
-  });
-
-  it("includes the task title only when opted in", () => {
-    const activity = buildActivity(activeIntent, {
-      ...baseOptions,
-      showTaskTitle: true,
-    });
-    expect(activity.details).toBe('Working on "Add Discord presence"');
-  });
-
-  it("includes the repo name only when opted in", () => {
-    const activity = buildActivity(activeIntent, {
-      ...baseOptions,
-      showRepoName: true,
-    });
-    expect(activity.state).toBe("posthog/code · agent running");
-  });
+const idleNoTask: PresenceIntent = {
+  hasActiveTask: false,
+  taskTitle: null,
+  repoName: null,
+  agentRunning: false,
+};
 
-  it("reflects review status with the idle badge when the agent is idle on a task", () => {
-    const activity = buildActivity(
-      { ...activeIntent, agentRunning: false },
-      { ...baseOptions, showRepoName: true },
-    );
-    expect(activity.state).toBe("posthog/code · reviewing");
-    expect(activity.assets?.small_image).toBe("posthog_idle");
-    expect(activity.assets?.small_text).toBe("Reviewing");
-  });
+interface Case {
+  name: string;
+  intent: PresenceIntent;
+  options: typeof baseOptions;
+  expected: {
+    details?: string;
+    state?: string;
+    smallImage?: string;
+    smallText?: string;
+    timestampStart?: number;
+    detailsMaxLength?: number;
+    detailsStartsWith?: string;
+    detailsEndsWith?: string;
+  };
+}
 
-  it("falls back to an idle/browsing presence with the idle badge when no task is focused", () => {
-    const activity = buildActivity(
-      {
-        hasActiveTask: false,
-        taskTitle: null,
-        repoName: null,
-        agentRunning: false,
-      },
-      { ...baseOptions, showTaskTitle: true, showRepoName: true },
-    );
-    expect(activity.details).toBe("Idle");
-    expect(activity.state).toBe("browsing");
-    expect(activity.assets?.small_image).toBe("posthog_idle");
-    expect(activity.assets?.small_text).toBe("Idle");
-  });
+const cases: Case[] = [
+  {
+    name: "hides task title and repo name by default (privacy-first)",
+    intent: activeIntent,
+    options: baseOptions,
+    expected: { details: "Working on a task", state: "agent running" },
+  },
+  {
+    name: "includes the task title only when opted in",
+    intent: activeIntent,
+    options: { ...baseOptions, showTaskTitle: true },
+    expected: { details: 'Working on "Add Discord presence"' },
+  },
+  {
+    name: "includes the repo name only when opted in",
+    intent: activeIntent,
+    options: { ...baseOptions, showRepoName: true },
+    expected: { state: "posthog/code · agent running" },
+  },
+  {
+    name: "shows the idle badge and review status when idle on a task",
+    intent: { ...activeIntent, agentRunning: false },
+    options: { ...baseOptions, showRepoName: true },
+    expected: {
+      state: "posthog/code · reviewing",
+      smallImage: "posthog_idle",
+      smallText: "Reviewing",
+    },
+  },
+  {
+    name: "falls back to idle/browsing with the idle badge when no task is focused",
+    intent: idleNoTask,
+    options: { ...baseOptions, showTaskTitle: true, showRepoName: true },
+    expected: {
+      details: "Idle",
+      state: "browsing",
+      smallImage: "posthog_idle",
+      smallText: "Idle",
+    },
+  },
+  {
+    name: "surfaces the running indicator asset and start timestamp while working",
+    intent: activeIntent,
+    options: baseOptions,
+    expected: { smallImage: "agent_running", timestampStart: STARTED_AT },
+  },
+  {
+    name: "truncates over-long titles to Discord's field limit, keeping prefix and ellipsis",
+    intent: { ...activeIntent, taskTitle: "x".repeat(200) },
+    options: { ...baseOptions, showTaskTitle: true },
+    expected: {
+      detailsMaxLength: 128,
+      detailsStartsWith: 'Working on "',
+      detailsEndsWith: "…",
+    },
+  },
+];
 
-  it("surfaces the running indicator asset while the agent works", () => {
-    const activity = buildActivity(activeIntent, baseOptions);
-    expect(activity.assets?.small_image).toBe("agent_running");
-    expect(activity.timestamps?.start).toBe(STARTED_AT);
-  });
+describe("buildActivity", () => {
+  it.each(cases)("$name", ({ intent, options, expected }) => {
+    const activity = buildActivity(intent, options);
 
-  it("truncates over-long titles to Discord's field limit", () => {
-    const longTitle = "x".repeat(200);
-    const activity = buildActivity(
-      { ...activeIntent, taskTitle: longTitle },
-      { ...baseOptions, showTaskTitle: true },
-    );
-    expect(activity.details).toBeDefined();
-    expect((activity.details as string).length).toBeLessThanOrEqual(128);
+    if (expected.details !== undefined) {
+      expect(activity.details).toBe(expected.details);
+    }
+    if (expected.state !== undefined) {
+      expect(activity.state).toBe(expected.state);
+    }
+    if (expected.smallImage !== undefined) {
+      expect(activity.assets?.small_image).toBe(expected.smallImage);
+    }
+    if (expected.smallText !== undefined) {
+      expect(activity.assets?.small_text).toBe(expected.smallText);
+    }
+    if (expected.timestampStart !== undefined) {
+      expect(activity.timestamps?.start).toBe(expected.timestampStart);
+    }
+    if (expected.detailsMaxLength !== undefined) {
+      expect(activity.details?.length).toBeLessThanOrEqual(
+        expected.detailsMaxLength,
+      );
+    }
+    if (expected.detailsStartsWith !== undefined) {
+      expect(activity.details?.startsWith(expected.detailsStartsWith)).toBe(
+        true,
+      );
+    }
+    if (expected.detailsEndsWith !== undefined) {
+      expect(activity.details?.endsWith(expected.detailsEndsWith)).toBe(true);
+    }
   });
 });