remove task detail prewarm from boot gate

Author: charlesvien

packages/ui/src/features/tasks/queries.ts

@@ -43,12 +43,3 @@ export function getCachedTaskDetail(taskId: string): Task | undefined {
     IMPERATIVE_QUERY_CLIENT,
   ).getQueryData<Task>(taskDetailQuery(taskId).queryKey);
 }
-
-// Warms the task-detail cache so a task route's first render finds its task
-// instead of flashing the route spinner (used by the boot loading gate).
-export async function ensureTaskDetailCached(taskId: string): Promise<void> {
-  if (getCachedTaskDetail(taskId) ?? getCachedTask(taskId)) return;
-  await resolveService<ImperativeQueryClient>(IMPERATIVE_QUERY_CLIENT)
-    .ensureQueryData(taskDetailQuery(taskId))
-    .catch(() => undefined);
-}

packages/ui/src/shell/App.tsx

@@ -20,7 +20,6 @@ import { useOnboardingStore } from "@posthog/ui/features/onboarding/onboardingSt
 import { SettingsDialog } from "@posthog/ui/features/settings/SettingsDialog";
 import { UpdateBanner } from "@posthog/ui/features/sidebar/components/UpdateBanner";
 import { PendingPromptRecovery } from "@posthog/ui/features/task-detail/components/PendingPromptRecovery";
-import { ensureTaskDetailCached } from "@posthog/ui/features/tasks/queries";
 import { router } from "@posthog/ui/router/router";
 import { AppLoadingScreen } from "@posthog/ui/shell/AppLoadingScreen";
 import { track } from "@posthog/ui/shell/analytics";
@@ -36,10 +35,6 @@ interface AppProps {
   devToolbar?: ReactNode;
 }
 
-// Cap on how long the boot gate waits for the restored task to fetch, so a
-// slow or hung request can never block app startup.
-const BOOT_WARMUP_MAX_MS = 5_000;
-
 function App({ devToolbar }: AppProps) {
   const { isBootstrapped } = useAuthSession();
   const authState = useAuthStateValue((state) => state);
@@ -94,28 +89,18 @@ function App({ devToolbar }: AppProps) {
     !needsInviteCode &&
     !needsAiApproval;
 
-  // Run the initial route's loaders and warm its task data before the router
-  // ever mounts, so the boot loading screen holds until the app is ready and
-  // no route spinner flashes.
+  // Run the initial route's loaders before the router ever mounts, so the boot
+  // loading screen holds until the route is ready.
   const [initialRouteLoaded, setInitialRouteLoaded] = useState(false);
   useEffect(() => {
     if (initialRouteLoaded || !readyForMainApp) return;
     let cancelled = false;
-    const holdWhileLoading = async () => {
-      await router.load().catch(() => undefined);
-      const taskId = router.state.matches
-        .map((match) => (match.params as { taskId?: string }).taskId)
-        .find(Boolean);
-      if (taskId) {
-        await Promise.race([
-          ensureTaskDetailCached(taskId),
-          new Promise((resolve) => setTimeout(resolve, BOOT_WARMUP_MAX_MS)),
-        ]);
-      }
-    };
-    void holdWhileLoading().finally(() => {
-      if (!cancelled) setInitialRouteLoaded(true);
-    });
+    void router
+      .load()
+      .catch(() => undefined)
+      .finally(() => {
+        if (!cancelled) setInitialRouteLoaded(true);
+      });
     return () => {
       cancelled = true;
     };