Skip to content

Commit e51a417

Browse files
committed
refactor(sidebar): hoist the cloud badge meta to a module constant
The inline `{ Icon: CloudIcon, label: "Cloud" }` fallback allocated a new object on every TaskIcon render; a module-level CLOUD_BADGE_META matches the PR_STATE_META / DIFF_META pattern. Generated-By: PostHog Code Task-Id: 3c36b344-ed49-424a-9218-703049ad89db
1 parent 04e39d6 commit e51a417

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

  • packages/ui/src/features/sidebar/components/items

packages/ui/src/features/sidebar/components/items/TaskIcon.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ const DIFF_META: PrStateMeta = {
196196
color: "var(--amber-11)",
197197
label: "Has changes",
198198
};
199+
const CLOUD_BADGE_META: OriginProductMeta = { Icon: CloudIcon, label: "Cloud" };
199200

200201
function PrStatusIcon({
201202
prState,
@@ -363,9 +364,7 @@ export function TaskIcon({
363364
hasDiff={hasDiff}
364365
size={size}
365366
provenanceBadge={
366-
isCloudTask
367-
? (originProductMeta ?? { Icon: CloudIcon, label: "Cloud" })
368-
: undefined
367+
isCloudTask ? (originProductMeta ?? CLOUD_BADGE_META) : undefined
369368
}
370369
threadUrl={
371370
isCloudTask && originProductMeta ? slackThreadUrl : undefined

0 commit comments

Comments
 (0)