parameterize watchdog visibility cases

Author: charlesvien

packages/ui/src/shell/useAppVisibilityWatchdog.test.ts

@@ -39,13 +39,57 @@ afterEach(() => {
 });
 
 describe("useAppVisibilityWatchdog", () => {
-  it("reports when the main app is mounted but invisible", () => {
+  it.each([
+    {
+      name: "invisible via opacity",
+      opacity: "0",
+      width: 1200,
+      height: 800,
+      active: true,
+      reports: true,
+    },
+    {
+      name: "collapsed to zero size",
+      opacity: "1",
+      width: 0,
+      height: 0,
+      active: true,
+      reports: true,
+    },
+    {
+      name: "visible",
+      opacity: "1",
+      width: 1200,
+      height: 800,
+      active: true,
+      reports: false,
+    },
+    {
+      name: "inactive",
+      opacity: "0",
+      width: 1200,
+      height: 800,
+      active: false,
+      reports: false,
+    },
+  ])(
+    "reports=$reports when $name",
+    ({ opacity, width, height, active, reports }) => {
+      const ref = { current: mountElement(opacity, width, height) };
+      renderHook(() => useAppVisibilityWatchdog(ref, active));
+
+      vi.advanceTimersByTime(3000);
+
+      expect(captureException).toHaveBeenCalledTimes(reports ? 1 : 0);
+    },
+  );
+
+  it("reports the element's opacity and source", () => {
     const ref = { current: mountElement("0", 1200, 800) };
     renderHook(() => useAppVisibilityWatchdog(ref, true));
 
     vi.advanceTimersByTime(3000);
 
-    expect(captureException).toHaveBeenCalledOnce();
     expect(captureException).toHaveBeenCalledWith(
       expect.any(Error),
       expect.objectContaining({
@@ -55,33 +99,6 @@ describe("useAppVisibilityWatchdog", () => {
     );
   });
 
-  it("reports when the main app has collapsed to zero size", () => {
-    const ref = { current: mountElement("1", 0, 0) };
-    renderHook(() => useAppVisibilityWatchdog(ref, true));
-
-    vi.advanceTimersByTime(3000);
-
-    expect(captureException).toHaveBeenCalledOnce();
-  });
-
-  it("stays silent when the main app is visible", () => {
-    const ref = { current: mountElement("1", 1200, 800) };
-    renderHook(() => useAppVisibilityWatchdog(ref, true));
-
-    vi.advanceTimersByTime(3000);
-
-    expect(captureException).not.toHaveBeenCalled();
-  });
-
-  it("does nothing while inactive", () => {
-    const ref = { current: mountElement("0", 1200, 800) };
-    renderHook(() => useAppVisibilityWatchdog(ref, false));
-
-    vi.advanceTimersByTime(3000);
-
-    expect(captureException).not.toHaveBeenCalled();
-  });
-
   it("does not report after unmounting before the deadline", () => {
     const ref = { current: mountElement("0", 1200, 800) };
     const { unmount } = renderHook(() => useAppVisibilityWatchdog(ref, true));