refactor: memoize built-in battery detection at module level

Generated-By: PostHog Code
Task-Id: 6b1cbbfe-903b-400d-a76f-45e614c6d0f8

Author: robbie-c

apps/code/src/main/platform-adapters/electron-power-manager.ts

@@ -9,8 +9,6 @@ const execFileAsync = promisify(execFile);
 
 @injectable()
 export class ElectronPowerManager implements IPowerManager {
-  private hasBuiltInBatteryResult: Promise<boolean> | null = null;
-
   public onResume(handler: () => void): () => void {
     powerMonitor.on("resume", handler);
     return () => powerMonitor.off("resume", handler);
@@ -26,13 +24,13 @@ export class ElectronPowerManager implements IPowerManager {
   }
 
   public hasBuiltInBattery(): Promise<boolean> {
-    if (!this.hasBuiltInBatteryResult) {
-      this.hasBuiltInBatteryResult = detectBuiltInBattery().catch(() => false);
-    }
-    return this.hasBuiltInBatteryResult;
+    memoizedBuiltInBattery ??= detectBuiltInBattery().catch(() => false);
+    return memoizedBuiltInBattery;
   }
 }
 
+let memoizedBuiltInBattery: Promise<boolean> | null = null;
+
 async function detectBuiltInBattery(): Promise<boolean> {
   switch (process.platform) {
     case "darwin": {