Commit ff7e096
authored
fix(sessions): auto-recover + report the chat SessionView render-loop crash
The task Chat panel sometimes shows "Something went wrong / Minified React
error #185" (Maximum update depth exceeded) when navigating back to a task, and
stays stuck on the fallback. Issue #2165 notes the loop is transient — "Try
again recovers it" — so the render loop trips once and clears on the next mount.
Two problems on `main`:
- The SessionView boundary keys recovery on `resetKey={taskId}`, which doesn't
change when you return to the same task, so a transient error strands the user
until they manually retry.
- That boundary was wired to the bare `ErrorBoundary` primitive (no `onError`),
so these crashes no longer report to error tracking — the historical
`boundary_name:"SessionView"` events came from older builds using the shell
wrapper.
Changes:
- Add opt-in, bounded `autoRecover` to the `ErrorBoundary` primitive. On catch it
reports via `onError` first, then schedules up to 2 self-resets (replaying the
manual "Try again"); while pending it renders nothing instead of flashing the
error UI. A persistent loop still lands on the manual fallback — no unbounded
retry storm — and the budget refills after a healthy stretch.
- Point the SessionView boundary at the telemetry-reporting shell `ErrorBoundary`
and enable `autoRecover`, restoring observability and auto-healing the
transient loop.
Does not change the underlying (layout-timing) loop trigger, which needs the
real app to reproduce; restored telemetry will confirm whether it still fires.
Refs #2165
Generated-By: PostHog Code
Task-Id: 24d17b80-ad39-4217-9eb6-dcc5ad043fb81 parent 0092213 commit ff7e096
3 files changed
Lines changed: 214 additions & 6 deletions
File tree
- packages/ui/src
- features/task-detail/components
- primitives
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
166 | 170 | | |
167 | 171 | | |
168 | 172 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
5 | 19 | | |
6 | 20 | | |
7 | 21 | | |
8 | 22 | | |
9 | 23 | | |
10 | 24 | | |
11 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
12 | 36 | | |
13 | 37 | | |
14 | 38 | | |
| |||
30 | 54 | | |
31 | 55 | | |
32 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
33 | 61 | | |
34 | 62 | | |
35 | 63 | | |
36 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
37 | 72 | | |
38 | 73 | | |
39 | 74 | | |
| |||
44 | 79 | | |
45 | 80 | | |
46 | 81 | | |
47 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
48 | 85 | | |
49 | 86 | | |
50 | 87 | | |
| |||
53 | 90 | | |
54 | 91 | | |
55 | 92 | | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
56 | 149 | | |
57 | 150 | | |
58 | 151 | | |
59 | | - | |
| 152 | + | |
| 153 | + | |
60 | 154 | | |
61 | 155 | | |
62 | 156 | | |
63 | | - | |
| 157 | + | |
64 | 158 | | |
65 | 159 | | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
66 | 166 | | |
67 | 167 | | |
68 | 168 | | |
| |||
0 commit comments