Skip to content

feat(skills): auto-bundle declared skill dependencies in cloud runs#3057

Merged
tatoalo merged 3 commits into
mainfrom
cloud-skills-dependency-autobundle
Jul 1, 2026
Merged

feat(skills): auto-bundle declared skill dependencies in cloud runs#3057
tatoalo merged 3 commits into
mainfrom
cloud-skills-dependency-autobundle

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Problem

skills that depend on other skills required the user to tag every dependency by hand in a cloud run. Tagging only the parent skill left its dependency missing in the sandbox, so the parent couldn't invoke it.

Changes

auto-bundle a tagged skill's declared dependencies for cloud runs:

  • add an optional dependencies: list to SKILL.md frontmatter (parseSkillDependencies, supports block and flow YAML sequences).
  • SkillsService.resolveSkillBundleDependencies transitively expands a set of skill refs to include declared dependencies (BFS, cycle-guarded; skills that resolve to a built-in already present in the sandbox are skipped). Exposed via skills.resolveDependencies.
  • CloudArtifactService.loadCloudSkillBundles expands refs through that resolver before uploading, so the dependency bundles ride along on both the initial and follow-up upload paths. No-op when there are no tagged skills

tatoalo commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 3fe9f10.

@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "feat(skills): auto-bundle declared skill..." | Re-trigger Greptile

Comment thread packages/workspace-server/src/services/skills/skills.ts Outdated
Comment thread packages/workspace-server/src/services/skills/parse-skill-frontmatter.ts Outdated
@tatoalo tatoalo self-assigned this Jul 1, 2026
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 1, 2026
@tatoalo tatoalo force-pushed the cloud-skills-first-message-bundle branch from 6cf04be to aad38ac Compare July 1, 2026 13:35
@tatoalo tatoalo force-pushed the cloud-skills-dependency-autobundle branch from a569f38 to add6912 Compare July 1, 2026 13:35
@tatoalo tatoalo marked this pull request as ready for review July 1, 2026 13:40
github-actions[bot]
github-actions Bot previously approved these changes Jul 1, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No showstoppers. The dependency-resolution feature is well-structured, follows project DI and layering conventions, and both P2 bot-flagged issues (RegExp metacharacter injection and silent truncation) were properly addressed before the current head.

@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "feat(skills): auto-bundle declared skill..." | Re-trigger Greptile

@tatoalo tatoalo force-pushed the cloud-skills-dependency-autobundle branch from add6912 to 42720c8 Compare July 1, 2026 13:48
@github-actions github-actions Bot dismissed their stale review July 1, 2026 13:48

New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-structured additive feature with proper layering: fs operations in workspace-server, types/tokens in core, thin tRPC router forwarding, and DI wiring only in the host. Both P2 issues flagged by the bot reviewer (regex injection and silent truncation) were addressed before the current HEAD — the fix uses startsWith instead of new RegExp(key), and the BFS now throws on graph size overflow rather than silently truncating. Cycle detection via seen set is correct, tests cover transitive deps, cycles, built-ins, and the oversized-graph error path.

Base automatically changed from cloud-skills-first-message-bundle to main July 1, 2026 13:57
@tatoalo tatoalo enabled auto-merge (squash) July 1, 2026 13:58
@stamphog

stamphog Bot commented Jul 1, 2026

Copy link
Copy Markdown

Retaining stamphog approval — delta since last review classified as merge_only.

@tatoalo tatoalo merged commit a9ea651 into main Jul 1, 2026
24 checks passed
@tatoalo tatoalo deleted the cloud-skills-dependency-autobundle branch July 1, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant