fix(agent): apply local-skill context on the codex adapter#3058
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "fix(agent): apply local-skill context on..." | Re-trigger Greptile |
a569f38 to
add6912
Compare
3cddfff to
392d5c1
Compare
There was a problem hiding this comment.
Clean bug fix that mirrors existing Claude adapter behavior in the Codex adapter. Defensive guards prevent the broken-mix edge case, all bot review comments were addressed (guard for missing localSkillName, parameterized tests), and no API contracts, data models, or dependencies are touched.
|
Reviews (2): Last reviewed commit: "fix(agent): apply local-skill context on..." | Re-trigger Greptile |
392d5c1 to
1ac275a
Compare
add6912 to
42720c8
Compare
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
|
Retaining stamphog approval — delta since last review classified as |

Problem
Local skills didn't actually apply on the Codex adapter. The agent-server sets
_meta.localSkillContext(the resolved skill instructions) and leaves the raw/skillslash command in the prompt; the Claude adapter consumes that meta, dropping the/skillchunk and injecting the instructions — but the Codex adapter had no such seam, so the bare/skillreached codex-acp and the skill instructions were ignored.Changes
prependLocalSkillContextto the Codex adapter, mirroring the Claude adapter'spromptToClaudehandling: drop the leading/skillchunk (the context already carries the user's args), prepend the resolved skill instructions as a text block, and strip the local-skill_metabefore forwarding to codex-acpisLocalSkillCommandChunkhelper intoadapters/local-skill.ts, now imported by both the Codex and Claude adapters (previously duplicated)