feat(code): condense plan approval options

[adboio]

Problem

plan approval options are getting 🥜

Changes

made them nice and condensed - two buttons:

1. yes, with mode dropdown
2. no, with feedback line

user's last plan approval mode is stored and used as the default, falling back to "auto"

How did you test this?

manually, storybook

Automatic notifications

• Publish to changelog?
• Alert Sales and Marketing teams?

[adboio]

• feat(code): condense plan approval options #3066 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

React Doctor found no issues in the changed files. 🎉

_{Reviewed by React Doctor for commit 7bdef00.}

[greptile-apps]

_{Reviews (1): Last reviewed commit: "feat(code): condense plan approval optio..." | Re-trigger Greptile}

[greptile-apps]

Tests 1 and 2 exercise the same behaviour (initial mode pre-selection on approve) with different inputs; the team prefers parameterised tests. A single it.each table would express both cases more concisely and make it easy to add future combinations (e.g., a remembered mode that is no longer in the options list).

Suggested change

	it("defaults to auto when there is no prior or remembered mode", async () => {
	const user = userEvent.setup();
	const { onSelect } = renderSelector([
	AUTO,
	ACCEPT_EDITS,
	DEFAULT_MODE,
	REJECT,
	]);
	await user.click(screen.getByText("Approve and proceed"));
	expect(onSelect).toHaveBeenCalledTimes(1);
	expect(onSelect).toHaveBeenCalledWith("auto");
	});
	it("defaults to the remembered last choice over the auto fallback", async () => {
	const user = userEvent.setup();
	useSettingsStore.setState({ lastPlanApprovalMode: "acceptEdits" });
	const { onSelect } = renderSelector([AUTO, ACCEPT_EDITS, DEFAULT_MODE]);
	await user.click(screen.getByText("Approve and proceed"));
	expect(onSelect).toHaveBeenCalledWith("acceptEdits");
	});
	it.each([
	{
	label: "no prior or remembered mode",
	lastMode: null as null,
	options: [AUTO, ACCEPT_EDITS, DEFAULT_MODE, REJECT],
	expected: "auto",
	},
	{
	label: "remembered last choice over the auto fallback",
	lastMode: "acceptEdits" as const,
	options: [AUTO, ACCEPT_EDITS, DEFAULT_MODE],
	expected: "acceptEdits",
	},
	])("defaults to $expected when $label", async ({ lastMode, options, expected }) => {
	const user = userEvent.setup();
	useSettingsStore.setState({ lastPlanApprovalMode: lastMode });
	const { onSelect } = renderSelector(options);
	await user.click(screen.getByText("Approve and proceed"));
	expect(onSelect).toHaveBeenCalledTimes(1);
	expect(onSelect).toHaveBeenCalledWith(expected);
	});

Context Used: Do not attempt to comment on incorrect alphabetica... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

Duplicate string literals in fallback path

The strings "Implementation Plan" and "Approve this plan to proceed?" appear verbatim in both the degenerate-case ActionSelector fallback (lines 194–196) and the main render path (lines 248–254). Extracting them to constants at the top of the function would satisfy OnceAndOnlyOnce and prevent the two copies from drifting.

Context Used: Do not attempt to comment on incorrect alphabetica... (source)