refactor: move connectivity service into effect

[jonathanlab]

Problem

Changes

How did you test this?

Automatic notifications

• Publish to changelog?
• Alert Sales and Marketing teams?

[jonathanlab]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• refactor: move connectivity service into effect #3098 👈 (View in Graphite)
• refactor: first effect vertical slice #3097
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

React Doctor found no issues in the changed files. 🎉

_{Reviewed by React Doctor for commit 0d691ce.}

[greptile-apps]

Comments Outside Diff (1)

1. packages/workspace-server/src/services/connectivity/service.test.ts, line 461-581 (link)

   Missing coverage for the changes stream

   The old test suite had four dedicated tests verifying the status-change event behaviour: emits on going offline after confirmation, suppresses a single transient failure, emits on coming back online, and does not emit when status is unchanged. All four were deleted and have no equivalent for the new SubscriptionRef.changes path. The duplicate-suppression guard in setOnline and the threshold logic in runCheck are relied on by subscribers but are now exercised only indirectly. Adding it.effect cases that assert on SubscriptionRef.changes (or Stream.toArray over a bounded stream) would close this gap.

   Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

_{Reviews (1): Last reviewed commit: "refactor: move connectivity service into..." | Re-trigger Greptile}