fix(sessions): dedupe cloud prompt echo when attachments add a summary#3100
Merged
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(sessions): dedupe cloud prompt echo ..." | Re-trigger Greptile |
There was a problem hiding this comment.
Targeted bug fix for cloud prompt deduplication — extracts a shared constant and stripping function, adjusts the merge logic to handle attachment summaries, and propagates echoed attachments onto the pinned bubble. Import direction is correct, all review comments were addressed, and test coverage follows conventions.
Contributor
|
Reviews (2): Last reviewed commit: "refactor(sessions): share attachment sum..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating a cloud task with an attachment rendered the user's prompt twice. The pinned optimistic bubble is seeded from the task description, which appends an
Attached files: <names>line, while the echoedsession/promptcarries attachments asresource_linkblocks with no such line — so the text-based dedupe inmergeConversationItemsnever matched and both bubbles rendered.Changes
stripTrailingAttachmentSummaryto@posthog/core/editor/cloud-promptand fold it into the dedupe key inmergeConversationItems, so the description-seeded placeholder matches its echo.