feat(updates): add "Later" option to dismiss the update-ready banner#3101
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "feat(updates): add Later option to dismi..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Generated-By: PostHog Code Task-Id: a6923a11-0949-4de3-8471-9832f711fb51
tatoalo
added
the
Stamphog
The update-ready banner only offered Restart, forcing an install decision mid-flow. Add a Later action (sidebar variant) and a dismiss X (compact variant) that hide the banner for the current session. Dismissal is keyed to the downloaded version in an in-memory view store, so a newer update re-shows the banner and it resurfaces on the next session. The sidebar ready card is restructured into two rows so the actions fit at sidebar width without wrapping the version text. Generated-By: PostHog Code Task-Id: a6923a11-0949-4de3-8471-9832f711fb51
tatoalo
force-pushed
the
posthog-code/update-banner-later-dismiss
branch
from
9e11033 to
1886956
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Low-risk UI-only change that adds a dismiss button to the update banner. The new store is correctly placed as view state in @posthog/ui, the greptile bot's concern about null-version key collisions is genuinely addressed by resetting dismissal on each new download cycle, and there are no architectural violations or security concerns.
|
Reviews (2): Last reviewed commit: "feat(updates): add Later option to dismi..." | Re-trigger Greptile |
1 participant
Problem
The update-ready notification only offers Restart, which forces an install decision mid-flow and breaks focus during active work. There is no way to dismiss it.
Changes
updateBannerStore), so the banner resurfaces on the next session. A dismissed update still installs silently on the next quit (autoInstallOnAppQuit)