feat(updates): add setting to dismiss update banners#3107
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "add setting to dismiss update banners" | Re-trigger Greptile |
There was a problem hiding this comment.
T1d feature with zero reviews that silently removes the always-visible "Later" dismiss button from the update-ready banner for all existing users — it's now gated behind a new setting that defaults to off. This is a user-facing behavioral regression that warrants human sign-off before merging.
There was a problem hiding this comment.
The PR removes the always-visible "Later" dismiss button from the update-ready banner and replaces it with a new dismiss button gated behind a setting that defaults to off — a user-facing behavioral regression for all existing users. A bot review flagged this exact concern on an older commit, and the current diff still exhibits the same behavior. No human has reviewed this change.
Problem
#3101 made the update-ready banner dismissible by adding a "Later" button, which grew the banner into a two-row card. Update banners are meant to stay concise, and dismissal should be opt-in without changing the default UI.
Changes
Screenshots
Screenshots come from the dev app with a forced update state, since the updater is disabled in dev builds. Images are hosted on the
pr-3107-assetsbranch; delete it after merge if unwanted.How did you test this?
UpdateBanner.test.tsx(7 cases): no dismiss button when the setting is off and dismissal when it is on, both parameterised across the sidebar and compact variants; dismissal holds across the update cycle; a newer version resurfaces the banner; turning the setting off restores a dismissed banner.dismissibleUpdateBannersto the settings store rehydrate test table.pnpm typecheck(22 packages),biome checkon the changed files and the full@posthog/uivitest suite all pass.Automatic notifications