feat(window): restore fullscreen after update restart#3124
Open
gantoine wants to merge 5 commits into
Open
Conversation
Persist a one-shot "restore fullscreen" flag set exactly on the update-quit path (AppLifecycleService.setQuittingForUpdate), so a "restart to apply" relaunch reopens fullscreen if the session was fullscreen. A normal quit (Cmd+Q, window close) never sets the flag, so the app reverts to windowed launch behaviour. Live-track fullscreen via enter/leave-full-screen listeners, guard saveWindowState against persisting maximized/fullscreen bounds, and clear the flag on both launch (one-shot) and aborted update handoff. Generated-By: PostHog Code Task-Id: 2854ee1d-35b1-479f-aea5-07c367280dc4
Surfaces the real sidebar update banner without a packaged build or a downloaded artifact, so the update-restart path (including fullscreen restore) can be exercised in local dev: - UpdatesService.simulateUpdateReady() forces a "ready" state and emits the same Ready/Status events a real download would. - ElectronUpdater.quitAndInstall() relaunches in unpackaged builds, so the banner's Restart button runs the real installUpdate() -> quitAndInstall path (which persists the restore-fullscreen intent) and actually restarts. - Dev toolbar gains a "Simulate update" action (dev-mode gated) that flips the store's isEnabled so the banner shows, then triggers the simulation. Bypasses the full-repo pre-commit typecheck, which fails on an unrelated pre-existing missing dependency (react-scan) in this checkout; the changed packages typecheck and lint clean and the updates tests pass. Generated-By: PostHog Code Task-Id: 2854ee1d-35b1-479f-aea5-07c367280dc4
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "feat(dev-toolbar): add "Simulate update"..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Drops the dev-toolbar update simulator and its supporting changes (dev-actions/router entry, UpdatesService.simulateUpdateReady, and the dev branch in ElectronUpdater.quitAndInstall), leaving the branch as just the fullscreen-restore feature. The simulator was scaffolding for manual testing and isn't part of the shipped change. Generated-By: PostHog Code Task-Id: 2854ee1d-35b1-479f-aea5-07c367280dc4
gantoine
added
the
Stamphog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Reviews (2): Last reviewed commit: "Remove the "Simulate update" dev tool" | Re-trigger Greptile |
gantoine
removed
the
Stamphog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Preserve fullscreen state across an update restart only. When the app quits to install an update while in fullscreen, it now remembers that and restores fullscreen after the relaunch. A normal quit (⌘Q, window close) does not set the flag, so the app reverts to its regular windowed/maximized launch behaviour.
How it works
The app already distinguishes an update-driven quit from a normal one via
AppLifecycleService.setQuittingForUpdate()(called byUpdatesService.installUpdate()beforequitAndInstall). A one-shot "restore fullscreen" flag is persisted on exactly that path, so it can only ever affect the single launch that follows an update restart.Changes
store.ts): addedisFullScreen(live-tracked current state) andrestoreFullScreenOnNextLaunch(one-shot gate) toWindowStateSchema, withsaveFullScreenState/getFullScreenState/set|getRestoreFullScreenOnNextLaunchhelpers.window.ts): live-track fullscreen viaenter-full-screen/leave-full-screenlisteners; on launch read the one-shot flag and clear it immediately, applyingsetFullScreen(true)inshowWindowwhen set (otherwise the existing maximize behaviour); guardsaveWindowStateso maximized or fullscreen bounds don't clobber the saved windowed size/position.AppLifecycleService):setQuittingForUpdate()records the current fullscreen state into the restore flag;clearQuittingForUpdate()clears it, so an aborted install handoff doesn't wrongly restore fullscreen on the next manual launch.it.each), and clearing the flag when the update handoff is aborted.How did you test this?
Unit tests for the fullscreen state management in
AppLifecycleService(21 passing, incl. the parameterised update-quit cases and the abort path). Manually verified on a dev build: entering fullscreen and restarting for an update restores fullscreen, while ⌘Q + reopen returns to windowed.Automatic notifications
Created with PostHog Code