fix(agent): show skill name in permission prompt#3128
Open
jonathanlab wants to merge 1 commit into
Open
Conversation
The `Skill` tool had no case in `toolInfoFromToolUse`, so it fell through to the default branch and rendered as a bare "Skill" title. The permission prompt therefore read "Skill / Do you want to proceed?" with no indication of which skill was being invoked. Add a `Skill` case that surfaces the skill name from `input.skill` (e.g. "Skill: deep-research") and passes any `args` through as tool content. Generated-By: PostHog Code Task-Id: 6384bab0-9eeb-4f55-bfab-a6ee9e18ddd7
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(agent): show skill name in permissio..." | Re-trigger Greptile |
pauldambra
approved these changes
Jul 3, 2026
tatoalo
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Invoking a skill produced a permission prompt that read just "Skill / Do you want to proceed?" — with no indication of which skill was being run.
The raw Claude SDK tool name
Skillhad no case intoolInfoFromToolUse(packages/agent/src/adapters/claude/conversion/tool-use-to-acp.ts), so it fell through to thedefaultbranch →title: "Skill",kind: "other". In the UI,kind: "other"routes toDefaultPermission, which renders the bare title. (Notably,ToolCallViewalready has aSkilldisplay entry for the in-conversation view — only the permission path was missing it.)Fix
Add a
Skillcase that surfaces the skill name frominput.skill, so the prompt now reads "Skill: deep-research / Do you want to proceed?", and passes anyargsthrough as tool-call content.Kept
kind: "other"so it continues routing toDefaultPermission— no new component needed. A dedicatedSkillPermissionrenderer (icon + styling) could follow later.Verification
pnpm --filter @posthog/agent typecheck→ cleanbiome linton the changed file → no issues