feat(zoom): add zoom control commands to command menu#3135
Conversation
Generated-By: PostHog Code
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "feat(zoom): add zoom control commands to..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const view: Command[] = [ | ||
| { | ||
| id: "zoom-in", | ||
| label: "Zoom in", | ||
| keywords: "zoom increase larger", | ||
| icon: <ZoomInIcon className="h-3 w-3 text-gray-11" />, | ||
| action: "zoom-in", | ||
| shortcut: SHORTCUTS.ZOOM_IN, | ||
| onRun: () => | ||
| void resolveService<HostTrpcClient>( | ||
| HOST_TRPC_CLIENT, | ||
| ).os.zoomIn.mutate(), | ||
| }, | ||
| { | ||
| id: "zoom-out", | ||
| label: "Zoom out", | ||
| keywords: "zoom decrease smaller", | ||
| icon: <ZoomOutIcon className="h-3 w-3 text-gray-11" />, | ||
| action: "zoom-out", | ||
| shortcut: SHORTCUTS.ZOOM_OUT, | ||
| onRun: () => | ||
| void resolveService<HostTrpcClient>( | ||
| HOST_TRPC_CLIENT, | ||
| ).os.zoomOut.mutate(), | ||
| }, | ||
| { | ||
| id: "zoom-reset", | ||
| label: "Reset zoom", | ||
| keywords: "zoom actual size default", | ||
| icon: <MagnifyingGlassIcon className="h-3 w-3 text-gray-11" />, | ||
| action: "zoom-reset", | ||
| shortcut: SHORTCUTS.RESET_ZOOM, | ||
| onRun: () => | ||
| void resolveService<HostTrpcClient>( | ||
| HOST_TRPC_CLIENT, | ||
| ).os.resetZoom.mutate(), | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
view shadows the outer useAppView() result
The local const view: Command[] declared inside the commandSections useMemo uses the same name as the component-level const view = useAppView() at line 137. There is no actual bug today (the outer view is consumed before the useMemo via reviewTaskId), but any future edit inside this closure that mistakenly writes view.type instead of reviewTaskId will silently read the Command[] array rather than the router view. A distinct name like viewCommands avoids the trap entirely.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| ZOOM_IN: "mod+=", | ||
| ZOOM_OUT: "mod+-", | ||
| RESET_ZOOM: "mod+0", |
There was a problem hiding this comment.
KEYBOARD_SHORTCUTS reference array
ZOOM_IN, ZOOM_OUT, and RESET_ZOOM are registered in SHORTCUTS and will display correctly in the command palette, but none of them are added to the KEYBOARD_SHORTCUTS array (line 45 onwards). That array drives the "Show keyboard shortcuts" sheet (mod+/), so users consulting that reference will have no indication the zoom shortcuts exist.
1 participant
Problem
Zoom in/out/reset only existed in the native View menu, not in the command palette.
Changes
applyZoomfrommenu.ts, exposed viaIMainWindow+ostRPC routerHow did you test this?
Typecheck and lint on all touched packages.
Automatic notifications
Created with PostHog Code