-
Notifications
You must be signed in to change notification settings - Fork 50
feat(agent): bundle rtk with the agent package #3145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pauldambra
wants to merge
19
commits into
main
Choose a base branch
from
posthog-code/bundle-rtk-with-agent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a9b04fc
feat(agent): bundle rtk with the agent package
pauldambra 0146ce3
fix(agent): verify rtk archive checksum and harden test teardown
pauldambra 28c5868
refactor(agent): tidy rtk bundling from review feedback
pauldambra c016f35
fix(agent): preserve explicit POSTHOG_RTK over the desktop bundle def…
pauldambra 2168f7e
feat(agent): emit rtk token-savings telemetry at end of cloud run (#3…
pauldambra 4e5352d
fix(agent): stop rtk savings tests probing the machine's real rtk
pauldambra 1fced7a
fix(agent): clarify at-most-once emit semantics and harden rtk binary…
pauldambra 20cb39c
refactor: apply simplify pass
pauldambra 1bcf3c5
fix(agent): keep rtk cache rename on one filesystem and pin error-pat…
pauldambra 258e019
refactor: reuse signClaudeBinary for the bundled rtk binary
pauldambra 99e4db6
fix(agent): download rtk into the per-process temp dir and polish rev…
pauldambra 4763eb5
docs(agent): correct two review-pass comments
pauldambra 5fe748e
feat(agent): emit rtk savings as a gauge snapshot, not a per-run delta
pauldambra 2516812
fix(agent): key the rtk savings counter to the task and drop the pct …
pauldambra e6bd533
feat(agent): report the rtk savings gauge from desktop daily
pauldambra 7b77dfd
refactor(agent): register the rtk gauge in the typed analytics event map
pauldambra 36ed5d2
fix(agent): polish the desktop rtk gauge wiring from review
pauldambra b9c14cc
fix(agent): scrub the env passed to rtk gain
pauldambra bc53fab
fix(agent): probe rtk before rewriting commands through it
pauldambra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import { createHash } from "node:crypto"; | ||
| import { existsSync } from "node:fs"; | ||
| import { userInfo } from "node:os"; | ||
| import { | ||
| BUNDLED_RTK_DIR, | ||
| bundledRtkBinName, | ||
| resolveRtkSavings, | ||
| } from "@posthog/agent/server/rtk-savings"; | ||
| import type { RtkSavingsHost } from "@posthog/core/usage/identifiers"; | ||
| import type { IBundledResources } from "@posthog/platform/bundled-resources"; | ||
| import { machineId } from "node-machine-id"; | ||
|
|
||
| /** | ||
| * Reads the bundled rtk binary's cumulative savings tally for the desktop | ||
| * gauge report. The counter id hashes machine id + OS username because rtk's | ||
| * database lives in the OS user's app-data dir: two OS users on one machine | ||
| * are two distinct counters, and mixing their readings under one id would | ||
| * corrupt the consumer-side differencing. | ||
| */ | ||
| export function createRtkSavingsHost( | ||
| bundledResources: IBundledResources, | ||
| ): RtkSavingsHost { | ||
| let counterId: string | null = null; | ||
|
|
||
| return { | ||
| async readGauge() { | ||
| const binary = bundledResources.resolve( | ||
| `${BUNDLED_RTK_DIR}/${bundledRtkBinName()}`, | ||
| ); | ||
| if (!existsSync(binary)) return null; | ||
|
|
||
| const summary = await resolveRtkSavings({ | ||
| resolveBinary: () => binary, | ||
| }); | ||
| if (!summary) return null; | ||
|
|
||
| counterId ??= createHash("sha256") | ||
| .update(`${await machineId()}:${userInfo().username}`) | ||
| .digest("hex"); | ||
| return { counterId, ...summary }; | ||
| }, | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.