Skip to content

fix(bluebird): make the thread panel collapse stick when opening a task#3155

Open
k11kirky wants to merge 1 commit into
mainfrom
posthog-code/collapsible-thread-panel-task-view
Open

fix(bluebird): make the thread panel collapse stick when opening a task#3155
k11kirky wants to merge 1 commit into
mainfrom
posthog-code/collapsible-thread-panel-task-view

Conversation

@k11kirky

@k11kirky k11kirky commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Problem

In the Channels (project-bluebird) space, the thread panel docked on the right of a task has a collapse button, but collapsing it never stuck: opening any task called openThread, which unconditionally reset collapsed: false, overriding the persisted preference. The panel sprang open on every task open.

Changes

  • threadPanelStore.openThread now takes an expand option; the channel task route opens the thread with expand: false so the user's collapse preference is kept. Explicitly opening a thread from a feed card still force-expands.
  • Dropped the redundant store write in WebsiteChannelHome.handleOpenTask — the task route's mount effect already points the panel at the task.
  • Instrumented the collapse/expand toggle with Channel action events (collapse_thread / expand_thread, surface thread_panel).

How did you test this?

  • pnpm --filter @posthog/shared --filter @posthog/ui typecheck
  • Biome check on the touched files

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Why

Requested in the project-bluebird channel: the thread right panel should be collapsible when opening a task, and the choice should persist.


Created with PostHog Code

…a task

Opening a task force-expanded the thread panel via openThread's unconditional collapsed reset, so the persisted collapse preference never stuck. openThread now takes an expand option; the task route passes expand: false. Also instruments the collapse/expand toggle with Channel action events.

Generated-By: PostHog Code
Task-Id: 4c5a667e-7f05-4275-96de-d89eb67f9ee0
@trunk-io

trunk-io Bot commented Jul 5, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit e92cec1.

@k11kirky k11kirky marked this pull request as ready for review July 5, 2026 22:30
@greptile-apps

greptile-apps Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(bluebird): respect thread panel coll..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants