fix(bluebird): make the thread panel collapse stick when opening a task#3155
Open
k11kirky wants to merge 1 commit into
Open
fix(bluebird): make the thread panel collapse stick when opening a task#3155k11kirky wants to merge 1 commit into
k11kirky wants to merge 1 commit into
Conversation
…a task Opening a task force-expanded the thread panel via openThread's unconditional collapsed reset, so the persisted collapse preference never stuck. openThread now takes an expand option; the task route passes expand: false. Also instruments the collapse/expand toggle with Channel action events. Generated-By: PostHog Code Task-Id: 4c5a667e-7f05-4275-96de-d89eb67f9ee0
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(bluebird): respect thread panel coll..." | Re-trigger Greptile |
adamleithp
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Channels (project-bluebird) space, the thread panel docked on the right of a task has a collapse button, but collapsing it never stuck: opening any task called
openThread, which unconditionally resetcollapsed: false, overriding the persisted preference. The panel sprang open on every task open.Changes
threadPanelStore.openThreadnow takes anexpandoption; the channel task route opens the thread withexpand: falseso the user's collapse preference is kept. Explicitly opening a thread from a feed card still force-expands.WebsiteChannelHome.handleOpenTask— the task route's mount effect already points the panel at the task.Channel actionevents (collapse_thread/expand_thread, surfacethread_panel).How did you test this?
pnpm --filter @posthog/shared --filter @posthog/ui typecheckAutomatic notifications
Why
Requested in the project-bluebird channel: the thread right panel should be collapsible when opening a task, and the choice should persist.
Created with PostHog Code