fix(updates): Prefetch changelog when update is active#3211
Merged
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "prefetch changelog when update is active" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking View on the update banner showed a release notes skeleton for a few seconds. The GitHub releases query was gated on the modal being open, so the fetch only started on click even though the app already knew an update was pending.
Changes
useHasActiveUpdate()selector for the banner-visible update statuses (available, downloading, ready, installing).UpdateAvailableModalandWhatsNewModalnow enable their releases query as soon as an update is active instead of waiting for open, so the changelog is already in the query cache when clicked. The skeleton now only appears when the data genuinely is not in memory.How did you test this?
pnpm --filter @posthog/ui typecheckbiome checkon the updates featureAutomatic notifications