-
Notifications
You must be signed in to change notification settings - Fork 54
feat(sidebar): filter tasks by workspace type #3248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
28a3ce3
feat(sidebar): filter tasks by workspace type
MattPua 7e1d855
style(sidebar): fix biome import sorting and formatting
MattPua 04e75df
refactor(sidebar): derive workspace-mode lists from a single exhausti…
MattPua 601878e
feat(sidebar): move task-type filter into an Environment submenu
MattPua b89d628
Merge remote-tracking branch 'origin/main' into posthog-code/filter-t…
MattPua File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import type { WorkspaceMode } from "@posthog/shared"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { ALL_WORKSPACE_MODES, filterByWorkspaceMode } from "./buildSidebarData"; | ||
| import type { TaskData } from "./sidebarData.types"; | ||
|
|
||
| const task = (overrides: Partial<TaskData>): TaskData => ({ | ||
| id: "t", | ||
| title: "t", | ||
| createdAt: 0, | ||
| lastActivityAt: 0, | ||
| isGenerating: false, | ||
| isUnread: false, | ||
| isPinned: false, | ||
| needsPermission: false, | ||
| repository: null, | ||
| isSuspended: false, | ||
| folderPath: null, | ||
| cloudPrUrl: null, | ||
| branchName: null, | ||
| linkedBranch: null, | ||
| ...overrides, | ||
| }); | ||
|
|
||
| describe("filterByWorkspaceMode", () => { | ||
| const worktree = task({ id: "w", workspaceMode: "worktree" }); | ||
| const local = task({ id: "l", workspaceMode: "local" }); | ||
| const cloud = task({ id: "c", workspaceMode: "cloud" }); | ||
| const unknown = task({ id: "u", workspaceMode: undefined }); | ||
| const tasks = [worktree, local, cloud, unknown]; | ||
|
|
||
| it.each<{ | ||
| name: string; | ||
| enabledModes: readonly WorkspaceMode[]; | ||
| expected: TaskData[]; | ||
| }>([ | ||
| { | ||
| name: "returns all tasks when every mode is enabled", | ||
| enabledModes: ALL_WORKSPACE_MODES, | ||
| expected: tasks, | ||
| }, | ||
| { | ||
| name: "keeps only tasks whose mode is enabled, plus unknown-mode tasks", | ||
| enabledModes: ["local"], | ||
| expected: [local, unknown], | ||
| }, | ||
| { | ||
| name: "keeps multiple enabled modes", | ||
| enabledModes: ["worktree", "cloud"], | ||
| expected: [worktree, cloud, unknown], | ||
| }, | ||
| { | ||
| name: "keeps only unknown-mode tasks when nothing is enabled", | ||
| enabledModes: [], | ||
| expected: [unknown], | ||
| }, | ||
| ])("$name", ({ enabledModes, expected }) => { | ||
| expect(filterByWorkspaceMode(tasks, enabledModes)).toEqual(expected); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabledModes. If a mode is ever removed fromWorkspaceMode(e.g., going from 3 → 2 modes), a user with 3 persisted entries satisfies3 >= 2and bypasses the filter entirely — showing tasks for modes they thought they had disabled. UsingALL_WORKSPACE_MODES.every(m => enabledModes.includes(m))checks for actual set membership instead.