Restore task action row (diff button) on channel task detail#3381
Merged
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
k11kirky
marked this pull request as ready for review
July 15, 2026 12:45
Contributor
|
adamleithp
approved these changes
Jul 15, 2026
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The unified Bluebird chrome moved the task action row (branch selector, review-panel toggle, handoff, task actions) into ContentHeader, which is mounted only outside /website — so tasks opened inside a channel lost the diff button. Extract the row into TaskHeaderActions and mount it in WebsiteLayout's title bar on channel task details. Generated-By: PostHog Code Task-Id: be6411d8-6b0f-429a-ad62-11312e69f7ac
k11kirky
force-pushed
the
posthog-code/channel-task-diff-button
branch
from
July 15, 2026 13:36
548a51d to
4d2f448
Compare
Generated-By: PostHog Code Task-Id: 685b450e-680a-44fb-a565-c57e990e6a49
Generated-By: PostHog Code Task-Id: 685b450e-680a-44fb-a565-c57e990e6a49
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a task inside a channel (Bluebird Website space) no longer shows the diff button in the top right, so code changes made by the task can't be reviewed from there. Starting the same task from the "New task" tab (the /code space) still shows it.
The unified Bluebird chrome refactor (#3221) moved the task action row — branch selector, review-panel toggle (diff stats badge), handoff, skill buttons, task actions menu — from the code header bar into
ContentHeader, which is intentionally mounted only outside/website.WebsiteLayoutrenders its own title bar with just the breadcrumb, so channel task details lost the whole row.Changes
ContentHeaderinto a reusableTaskHeaderActionscomponent (pure move, no behavior change).WebsiteLayoutnow rendersTaskHeaderActionsin its title bar when on a channel task detail route, restoring the diff button (and the rest of the row) for channel-filed tasks.How did you test this?
WebsiteLayout.test.tsxasserting the action row renders on/website/$channelId/tasks/$taskIdand not on other channel routes — failed before the fix, passes after.@posthog/uisuite: 172 files / 1507 tests pass;pnpm --filter @posthog/ui typecheckand Biome clean.Automatic notifications
Created with PostHog Code