feat(agent): instruction-level rtk adoption for codex sessions#3491
Merged
Conversation
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
marked this pull request as ready for review
July 16, 2026 09:59
Contributor
|
Reviews (1): Last reviewed commit: "feat(agent): instruction-level rtk adopt..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The Claude adapter routes eligible commands through rtk deterministically via a PreToolUse hook, but the Codex app-server protocol has no command-rewrite channel, so cloud Codex runs never used the rtk binary installed in the sandbox. Append rtk usage guidance to the Codex developer instructions instead, mirroring the Claude hook's eligibility sets and gated on resolveRtkPrefix so the per-run POSTHOG_RTK=0 kill switch also disables it. Generated-By: PostHog Code Task-Id: b005dede-2677-4364-94a2-c2a7e90e376a
tatoalo
force-pushed
the
posthog-code/rtk-guidance-for-codex
branch
from
July 16, 2026 10:06
25a6909 to
2bcea32
Compare
tatoalo
added
the
Stamphog
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
No human teammate has reviewed the current head of this PR — the only current-head comments are the author's own replies to a bot. This is a behavioral change to how Codex agent instructions are built, which warrants at least one human sign-off before auto-approval.
stamphog
Bot
removed
the
Stamphog
jonathanlab
approved these changes
Jul 16, 2026
tatoalo
enabled auto-merge (squash)
July 16, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rtk only works on Claude cloud runs today: the Claude adapter rewrites eligible Bash commands through it deterministically with an in-SDK
PreToolUsehook. The Codex app-server protocol has no command-rewrite channel (native gap).Codex cloud runs should get the same command-output token savings as Claude runs and since Codex can't be hooked deterministically, the instruction channel is the integration point it reliably reads.
Changes
add
adapters/rtk-guidance.tsto generate RTK guidance for Codex, matching the Claude hook's supported command set and eligibility rules so behavior stays consistent across adaptersappend the guidance in
buildCodexInstructions, gated byresolveRtkPrefixso per-run RTK opt-outs also disable the instructionsexport the shared RTK command sets from
claude/session/rtk.tsto keep the guidance and hook in sync