feat(task-detail): show custom base image badge on cloud tasks#3492
Conversation
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
added
the
Stamphog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Purely additive UI component: adds a badge for cloud tasks using a custom base image. Hooks are correctly placed in the child component to avoid conditional-hook violations, type guards are defensive, the feature-flag gate in useSandboxCustomImages prevents unnecessary fetches, and openSettings is a plain function called correctly in an onClick handler. The memo dependency widening from task.title to task is the right fix given the new dependency on the full task object.
|
Reviews (1): Last reviewed commit: "chore(task-detail): trim comments in cus..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Cloud tasks that run on a custom base image (picked per run or inherited from the sandbox environment) now show a "Custom VM · <image name>" chip next to the workspace mode badge in the task header. Clicking it opens the cloud environments settings where custom images are managed. The badge renders independently of workspace-mode resolution so it isn't hidden while the workspace loads.
128536c to
e6a56c9
Compare
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
…3492) Ports the desktop custom base image badge to the React Native app. The task detail header now shows a violet "cube" badge with the custom sandbox base image name when a cloud run used a custom image (directly via custom_image_id or indirectly via its sandbox environment). The sandbox image and environment lists are fetched through the mobile app's authed-query pattern, and only when the latest run is a cloud run that carries a custom_image_id or sandbox_environment_id, so ordinary tasks add no extra network calls. The badge renders nothing when custom images are disabled or the image can't be resolved. Generated-By: PostHog Code Task-Id: 1230821c-af71-4788-b81f-dcaeb6442e2d
1 participant
Problem
When a cloud task runs on a custom base image, nothing on the task view says so.
Changes
CustomImageBadgein the task detail header, next to the workspace mode badge: aCustom VM · <image name>chip shown for cloud tasks whose latest run picked a custom image per run (state.custom_image_id) or inherited one from its sandbox environment