Skip to content

test(shared): cover explicit HTTPS port#3498

Draft
k11kirky wants to merge 2 commits into
mainfrom
posthog-code/test-safe-external-url-port
Draft

test(shared): cover explicit HTTPS port#3498
k11kirky wants to merge 2 commits into
mainfrom
posthog-code/test-safe-external-url-port

Conversation

@k11kirky

Copy link
Copy Markdown
Contributor

Problem

Add a harmless test-only change to exercise the pull request workflow.

Why: This dummy PR verifies the end-to-end signed commit and draft PR flow without changing production behavior.

Changes

  • Cover an explicit HTTPS port in isSafeExternalUrl tests.

How did you test this?

  • pnpm --filter @posthog/shared exec vitest run src/url.test.ts
  • pnpm exec biome check packages/shared/src/url.test.ts

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 864ed341-adf3-40b7-b37c-baef45c4f05d
@trunk-io

trunk-io Bot commented Jul 16, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 322e343.

Generated-By: PostHog Code
Task-Id: 864ed341-adf3-40b7-b37c-baef45c4f05d
@charlesvien charlesvien added the stale No recent changes to PR label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale No recent changes to PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants