Skip to content

fix(code): preserve wheel zoom across resize#3518

Open
richardsolomou wants to merge 3 commits into
mainfrom
posthog-code/fix-zoom-resize-consistency
Open

fix(code): preserve wheel zoom across resize#3518
richardsolomou wants to merge 3 commits into
mainfrom
posthog-code/fix-zoom-resize-consistency

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 16, 2026

Copy link
Copy Markdown
Member

Problem

Ctrl+wheel zoom could be overwritten after resize or reload. Failed persistence also left later gestures using a stale baseline.

Changes

Track logical zoom in memory, serialize competing zoom actions, and persist it as a best-effort side effect.

How did you test this?

  • pnpm --filter code exec vitest run src/main/zoom.test.ts
  • pnpm --filter code typecheck and pre-commit pnpm typecheck
  • Real Electron resize and reload testing

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: ec0186a8-c8b7-4b07-b526-5d58095df15c
@trunk-io

trunk-io Bot commented Jul 16, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit df08e60.

@posthog

posthog Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

@greptile-apps

greptile-apps Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(code): preserve wheel zoom across re..." | Re-trigger Greptile

Comment thread apps/code/src/main/zoom.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant