fix(code): preserve wheel zoom across resize#3518
Open
richardsolomou wants to merge 3 commits into
Open
Conversation
Generated-By: PostHog Code Task-Id: ec0186a8-c8b7-4b07-b526-5d58095df15c
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
Contributor
|
Reviews (1): Last reviewed commit: "fix(code): preserve wheel zoom across re..." | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: ec0186a8-c8b7-4b07-b526-5d58095df15c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ctrl+wheel zoom could be overwritten after resize or reload. Failed persistence also left later gestures using a stale baseline.
Changes
Track logical zoom in memory, serialize competing zoom actions, and persist it as a best-effort side effect.
How did you test this?
pnpm --filter code exec vitest run src/main/zoom.test.tspnpm --filter code typecheckand pre-commitpnpm typecheckAutomatic notifications
Created with PostHog Code