fix(code-review): keep expanded review open for comments#3519
Closed
MattPua wants to merge 1 commit into
Closed
Conversation
Generated-By: PostHog Code Task-Id: 3606bffb-74c3-41e4-9026-2b01798f4110
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Submitting comments while code review is expanded closes the expanded review and returns to the chat panel.
Changes
No screenshot included because this is a behavior-only fix.
How did you test this?
pnpm --filter @posthog/ui exec vitest run src/features/code-review/components/CommentAnnotation.test.tsx src/features/code-review/components/PendingReviewBar.test.tsx src/features/code-review/components/PrCommentThread.test.tsx src/features/sessions/sendPromptToAgent.test.tspnpm --filter @posthog/ui typecheckpnpm exec biome check packages/ui/src/features/code-review/components/CommentAnnotation.test.tsx packages/ui/src/features/code-review/components/PendingReviewBar.test.tsx packages/ui/src/features/code-review/components/CommentAnnotation.tsx packages/ui/src/features/code-review/components/PendingReviewBar.tsx packages/ui/src/features/code-review/components/PrCommentThread.tsx packages/ui/src/features/code-review/components/PrCommentThread.test.tsx packages/ui/src/features/sessions/sendPromptToAgent.ts packages/ui/src/features/sessions/sendPromptToAgent.test.tsAutomatic notifications
Created with PostHog Code