Skip to content

Lower handoff artifact warnings to debug #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 1 commit into from
Jul 17, 2026
Merged

Lower handoff artifact warnings to debug #3531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/agent/src/handoff-checkpoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export class HandoffCheckpointTracker {
!!capture.headPack && !uploads.pack?.storagePath;
const indexUploadMissing = !uploads.index?.storagePath;
if (packUploadMissing || indexUploadMissing) {
this.logger.warn(
this.logger.debug(
"Discarding handoff checkpoint: required artifact uploads did not complete",
Comment on lines +131 to 132

@greptile-apps greptile-apps Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unexpected Discards Lose Warning Signal

This branch also runs when required uploads are missing because direct and inline upload attempts failed, not only when an artifact exceeded its expected size limit. Log collectors that exclude debug entries will lose the final checkpoint-discard event and its checkpoint ID, upload state, and artifact sizes, making unexpected checkpoint loss harder to diagnose.

Suggested change
this.logger.debug(
"Discarding handoff checkpoint: required artifact uploads did not complete",
this.logger.warn(
"Discarding handoff checkpoint: required artifact uploads did not complete",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

{
checkpointId: capture.checkpoint.checkpointId,
Expand Down Expand Up @@ -245,7 +245,7 @@ export class HandoffCheckpointTracker {

const content = await readFile(filePath);
if (content.byteLength > MAX_ARTIFACT_UPLOAD_BYTES) {
this.logger.warn(
this.logger.debug(
"Skipping handoff artifact upload: file exceeds the artifact size limit",
{
name,
Expand Down
Loading