fix(code): restore external app icons#3563
Merged
Merged
Conversation
Run the macOS icon extractor from its unpacked binary and add cmux to the detected terminal applications. Generated-By: PostHog Code Task-Id: 02c8320e-3a8f-47a2-893a-6381dd31369c
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
charlesvien
approved these changes
Jul 19, 2026
|
An error occurred while submitting your PR to the queue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Packaged macOS builds silently lost external application icons because the extractor depended on hoisted runtime modules and an ASAR-sensitive executable path.
Changes
Run the bundled extractor directly from
app.asar.unpacked, remove the unusedp-mappackage, and register cmux as a detected terminal.How did you test this?
pnpm typecheck.Automatic notifications
Created with PostHog Code