fix(ui): stabilize archived task story timestamps#3574
Merged
Conversation
|
😎 Merged manually by @richardsolomou - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
richardsolomou
marked this pull request as ready for review
July 20, 2026 06:38
Contributor
|
Reviews (1): Last reviewed commit: "fix(ui): stabilize archived task story t..." | Re-trigger Greptile |
Contributor
|
✅ Visual changes approved by @richardsolomou — baseline updated in 7 changed. |
tatoalo
approved these changes
Jul 20, 2026
Generated-By: PostHog Code Task-Id: b21ae89d-1bf8-49fa-a781-cb96dae2e61f
7 updated Run: 1704bd4f-ebe9-4f96-bcc6-179d0679127e Co-authored-by: richardsolomou <2622273+richardsolomou@users.noreply.github.com>
richardsolomou
force-pushed
the
posthog-code/fix-archive-story-timestamps
branch
from
July 20, 2026 12:30
fac2185 to
70f9ef0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Why: The archived tasks story derived fixture dates from wall-clock time before the visual runner froze the browser clock. Unrelated PRs then produced changing screenshots, with future fixture dates rendered as
just now.Changes
I anchored the story timestamps to the same fixed date used by the Storybook visual runner, keeping relative and calendar labels deterministic.
How did you test this?
pnpm exec biome check packages/ui/src/features/archive/ArchivedTasksView.stories.tsx.pnpm --filter @posthog/ui typecheck.pnpm --filter code build-storybook.ManyTasksstory twice under the test-runner clock and confirmed byte-identical screenshots.Automatic notifications
Created with PostHog Code