fix(canvas): navigate share links in-app instead of via the browser by adboio · Pull Request #3582 · PostHog/code

adboio · 2026-07-20T13:29:54Z

Problem

Clicking a canvas link in a channel thread opened PostHog Cloud in the external browser, which then deep-linked back into PostHog Code — an unnecessary round-trip, since the user is already in the app.

Why: reported in-app annoyance — the click flashes out to the browser and back instead of just navigating. Confirmed live on latest main (not a stale local version).

Changes

The thread feed renders server-emitted announcement messages (e.g. "Name has been created") whose content embeds a portable https share link — deliberately portable so the same message works on web, Slack, and for users without the app. Those links were rendered as plain external anchors, so clicking one handed the URL to the OS browser → Cloud interstitial → posthog-code:// back into the app.

Fix at the client render/click layer (leaving the portable stored content intact):

New shareLinks.ts util — parses our own share-link URLs (/code/canvas/<channelId>/<dashboardId>, /code/channel/<channelId>[/tasks/<taskId>]) on a known PostHog host and navigates via the existing in-app router (navigationBridge), cancelling the default open-in-browser.
Wired into MentionText (thread sidebar + channel feed / activity / intro) and MarkdownRenderer (agent chat). Any link that isn't a recognized share link is untouched and still opens externally.

Host matching covers all PostHog regions (not just the signed-in one), since the inbound deep-link handlers already navigate by id against the current session — so intercepting is strictly faster with the same destination.

How did you test this?

pnpm --filter @posthog/ui exec vitest run src/utils/shareLinks.test.ts src/features/canvas/components/MentionText.test.tsx → 20 passed. Covers canvas / channel / channel+task parses, encoded ids, non-PostHog host + wrong-path + malformed rejection, and click interception (preventDefault + in-app navigate) vs. external links passing through.
Lint clean (biome check) and no typecheck errors in packages/ui/src for the changed files.
Not yet run: full-app manual verification (build blocked in this environment on an unrelated @posthog/agent dist build).

Automatic notifications

Publish to changelog?
Alert Sales and Marketing teams?

Created with PostHog Code

Clicking a canvas/channel share link in a channel thread bounced out to the browser (PostHog Cloud interstitial) which then deep-linked back into the app. The thread feed renders server-emitted announcement messages whose content embeds a portable https share link; those links were rendered as plain external anchors with no in-app interception. Add a client-side parser that recognizes our own share-link URLs (/code/canvas/... and /code/channel/...) and navigates via the in-app router, short-circuiting the browser round-trip. Wired into MentionText (thread + channel surfaces) and MarkdownRenderer (agent chat). External links are untouched. Generated-By: PostHog Code Task-Id: a3001315-524a-4902-b23c-5c6f5b010827

trunk-io · 2026-07-20T13:29:57Z

😎 Merged successfully - details.

github-actions · 2026-07-20T13:30:24Z

React Doctor found no issues in the changed files. 🎉

_{Reviewed by React Doctor for commit 0176546.}

Move parseShareLink next to canvasShareUrl/channelShareUrl in posthogLinks.ts so the /code/canvas and /code/channel path shapes live in one place (the parser is the inverse of the builders). Derive the recognized-host set from REGION_LABELS instead of a hardcoded region list. shareLinks.ts is now just the navigation glue (navigateToShareTarget/handleShareLinkClick). Generated-By: PostHog Code Task-Id: a3001315-524a-4902-b23c-5c6f5b010827

Generated-By: PostHog Code Task-Id: a3001315-524a-4902-b23c-5c6f5b010827

github-actions

Clean, well-tested UI fix that adds in-app navigation for PostHog share links. The host-allowlist validation is conservative (only known PostHog regions), URL decoding is defensive, and the fallback to normal browser navigation for non-matching links is intact. No architecture violations, no data model or API contract changes.

greptile-apps · 2026-07-20T14:17:10Z

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/ui/src/utils/shareLinks.ts:30-34
**Modified Click Loses New Tab**

When a user Ctrl/Cmd-clicks or Shift-clicks a recognized share link, this path consumes the event and navigates the current app. Both callers render `target="_blank"`, so modified clicks should retain the native new-tab or new-window behavior instead of replacing the current view.

_{Reviews (1): Last reviewed commit: "refactor(canvas): match share links agai..." | Re-trigger Greptile}

greptile-apps · 2026-07-20T14:17:14Z

+  if (!href) return false;
+  const target = parseShareLink(href);
+  if (!target) return false;
+  event.preventDefault();
+  navigateToShareTarget(target);


Modified Click Loses New Tab

When a user Ctrl/Cmd-clicks or Shift-clicks a recognized share link, this path consumes the event and navigates the current app. Both callers render target="_blank", so modified clicks should retain the native new-tab or new-window behavior instead of replacing the current view.

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/ui/src/utils/shareLinks.ts Line: 30-34 Comment: **Modified Click Loses New Tab** When a user Ctrl/Cmd-clicks or Shift-clicks a recognized share link, this path consumes the event and navigates the current app. Both callers render `target="_blank"`, so modified clicks should retain the native new-tab or new-window behavior instead of replacing the current view. How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

A Cmd/Ctrl/Shift/middle click on a share link is explicit intent to open it elsewhere; don't hijack it for in-app navigation. handleShareLinkClick now bails on modified clicks so the anchor's target="_blank" default runs. Generated-By: PostHog Code Task-Id: a3001315-524a-4902-b23c-5c6f5b010827

New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.

github-actions

Clean UI-only fix with comprehensive tests. The greptile bot's modified-click concern was resolved in a subsequent commit — the current diff shows isModifiedClick properly passes through meta/ctrl/shift/alt and middle-button clicks. Host allowlist is conservative and URL decoding is defensive.

adboio added 4 commits July 20, 2026 09:36

chore(canvas): drop comments from share-link code

089ba24

Generated-By: PostHog Code Task-Id: a3001315-524a-4902-b23c-5c6f5b010827

refactor(canvas): split share-link parsing into per-type helpers

6b0e4e7

Generated-By: PostHog Code Task-Id: a3001315-524a-4902-b23c-5c6f5b010827

refactor(canvas): match share links against a route table

4ce850e

Generated-By: PostHog Code Task-Id: a3001315-524a-4902-b23c-5c6f5b010827

adboio marked this pull request as ready for review July 20, 2026 14:13

adboio requested a review from a team July 20, 2026 14:13

adboio added the Stamphog This will request an autostamp by stamphog on small changes label Jul 20, 2026 — with Graphite App

github-actions Bot previously approved these changes Jul 20, 2026

View reviewed changes

greptile-apps Bot reviewed Jul 20, 2026

View reviewed changes

github-actions Bot approved these changes Jul 20, 2026

View reviewed changes

trunk-io Bot merged commit 351fd79 into main Jul 20, 2026
32 checks passed

trunk-io Bot deleted the posthog-code/canvas-link-in-app-nav branch July 20, 2026 14:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(canvas): navigate share links in-app instead of via the browser#3582

fix(canvas): navigate share links in-app instead of via the browser#3582
trunk-io[bot] merged 6 commits into
mainfrom
posthog-code/canvas-link-in-app-nav

adboio commented Jul 20, 2026

Uh oh!

trunk-io Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

greptile-apps Bot commented Jul 20, 2026

Uh oh!

greptile-apps Bot Jul 20, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

adboio commented Jul 20, 2026

Problem

Changes

How did you test this?

Automatic notifications

Uh oh!

trunk-io Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Jul 20, 2026

Uh oh!

greptile-apps Bot Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

trunk-io Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading