feat(code-review): filter files with comments#3590
Merged
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/code-review/components/ReviewShell.tsx:148-150
**Empty Data Reactivates Saved Filter**
When a PR URL or source becomes available again while `showCommentedFilesOnly` remains true, `commentedFilePaths` is initially an empty set while comments load. The filter therefore activates immediately and briefly replaces the review with “No files with comments,” even though the comment data is still pending; the active state should distinguish loading from a loaded empty result.
Reviews (1): Last reviewed commit: "feat(code-review): filter files with com..." | Re-trigger Greptile |
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
Generated-By: PostHog Code Task-Id: 199c1147-fca6-415b-9ea1-00a45d9b7267
MattPua
force-pushed
the
posthog-code/filter-commented-review-files
branch
from
July 20, 2026 17:06
60b97d9 to
0cae5d3
Compare
tatoalo
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pnpm --filter @posthog/ui exec vitest run src/features/code-reviewpnpm --filter @posthog/ui typecheckpnpm exec biome check packages/ui/src/features/code-review/components/CloudReviewPage.tsx packages/ui/src/features/code-review/components/ReviewPage.tsx packages/ui/src/features/code-review/components/ReviewShell.tsx packages/ui/src/features/code-review/components/ReviewToolbar.tsx packages/ui/src/features/code-review/components/reviewItemBuilders.tsx packages/ui/src/features/code-review/reviewShellParts.tsx packages/ui/src/features/code-review/reviewShellParts.test.tsxCreated with PostHog Code