feat(mobile): add "Any" option to inbox Source and Priority filters (port #3493)#3595
Open
Gilbert09 wants to merge 1 commit into
Open
feat(mobile): add "Any" option to inbox Source and Priority filters (port #3493)#3595Gilbert09 wants to merge 1 commit into
Gilbert09 wants to merge 1 commit into
Conversation
Ports #3493 to the mobile filter sheet. Adds an "Any" row at the top of the Source and Priority sections that reads as selected when the filter is empty and clears the filter back to empty when tapped. Source clears via a new clearSourceProductFilter store action; Priority reuses setPriorityFilter([]). Generated-By: PostHog Code Task-Id: be78b0df-c31b-4e0e-8d37-feaf22a054d0
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop inbox filters gained an "Any" option for Source and Priority in #3493, but the mobile filter sheet had no equivalent — there was no explicit way to see or reset to "no filtering" on those two sections.
Changes
Ports #3493 to
apps/mobile. Adds an "Any" row at the top of the Source and Priority sections of the filter sheet, matching the existing mobile filter-row styling:clearSourceProductFilterstore action (mirroring desktop); Priority reuses the existingsetPriorityFilter([]).Mobile only — no desktop code touched.
How did you test this?
inboxFilterStore.test.tswith a case for the newclearSourceProductFilteraction;vitest run src/features/inbox/stores/inboxFilterStore.test.tspasses (9/9).biome checkclean;tsc --noEmitreports no errors in the inbox feature.Automatic notifications
Created with PostHog Code