Group task configuration under settings#3612
Conversation
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
|
😎 Merged successfully - details. |
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
b46ec12 to
c13b3b4
Compare
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
f543a72 to
5a876ec
Compare
Reverts 5a876ec. Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
| "Environments", | ||
| EnvironmentsSettings, | ||
| ), | ||
| agents: defineSettingsPage("Agents", AgentsSettings), |
There was a problem hiding this comment.
Medium: AI approval gate bypass
A signed-in organization member awaiting admin approval can open Settings, select Agents, and use “Run setup agent,” which calls taskService.createTask with workspaceMode: "cloud" and executionMode: "auto". Prevent this category and its agent actions from rendering in the pre-router settings dialog until AI data processing has been approved.
There was a problem hiding this comment.
Confirmed: the pre-router approval screen can open the shared Settings panel, and this PR newly exposes the Agents setup action there. This commit does not address that approval-state behavior, so I am leaving the thread open rather than marking a valid concern resolved.
PR overviewThis pull request groups task-related configuration into the Settings experience, including settings content for agent setup and task execution options. It adds or exposes UI paths such as the Agents settings area and setup-agent action from the settings page. There is one open security concern: users who are signed in but still awaiting AI data-processing approval can reach the Agents settings flow and start an automatic cloud setup task. That creates a concrete approval-gate bypass for agent actions, though the impact appears limited to this pre-approval task execution path. No issues have been addressed yet, so the PR still needs a guard to hide or block these settings actions until approval is complete. Open issues (1)
Fixed/addressed: 0 · PR risk: 6/10 |
k11kirky
left a comment
There was a problem hiding this comment.
Automated review — findings inline.
Generated-By: PostHog Code Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
|
/trunk merge |
Problem
The primary navigation is becoming crowded with setup and configuration destinations that are used much less often than core workflows.
The navigation should prioritize daily actions—creating tasks, searching, reviewing the inbox, and using the command center. Configuration that is typically completed once or revisited occasionally should live in Settings, where it remains discoverable without competing with frequent work.
Why: Separate doing work from configuring how work gets done. This keeps the main navigation focused while giving task and agent configuration a clear home.
Changes
The information architecture follows one rule:
Screenshots
How did you test this?
pnpm --filter @posthog/ui typecheckgit diff --checkAutomatic notifications
Created with PostHog Code