Skip to content

Group task configuration under settings#3612

Merged
trunk-io[bot] merged 14 commits into
mainfrom
posthog-code/group-configure-settings
Jul 21, 2026
Merged

Group task configuration under settings#3612
trunk-io[bot] merged 14 commits into
mainfrom
posthog-code/group-configure-settings

Conversation

@puemos

@puemos puemos commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Problem

The primary navigation is becoming crowded with setup and configuration destinations that are used much less often than core workflows.

The navigation should prioritize daily actions—creating tasks, searching, reviewing the inbox, and using the command center. Configuration that is typically completed once or revisited occasionally should live in Settings, where it remains discoverable without competing with frequent work.

Why: Separate doing work from configuring how work gets done. This keeps the main navigation focused while giving task and agent configuration a clear home.

Changes

  • Replace the separate Agents, Skills, and MCP servers navigation entries with one Configure entry that opens Settings with Agents selected.
  • Group Settings by concern: Account, Workspace, Configure, Experience, Integrations, and Application.
  • Place Agents, Skills, MCP servers, Claude Code, and Self-driving together under Configure.
  • Make Settings the canonical home for Skills and MCP servers while preserving legacy URLs through redirects.
  • Preserve existing configuration behavior and full-height pages, and consistently fall back from categories unavailable on the current host.

The information architecture follows one rule:

  • Navigation: destinations and actions used regularly
  • Settings: setup, customization, integrations, and lower-frequency configuration

Screenshots

Grouped Settings navigation Configure settings

How did you test this?

  • Focused settings visibility tests
  • Biome checks on touched files
  • pnpm --filter @posthog/ui typecheck
  • git diff --check

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
@trunk-io

trunk-io Bot commented Jul 21, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found 1 issue in 1 file · 1 warning.

1 warning

src/features/settings/components/SettingsPanel.tsx

Reviewed by React Doctor for commit 7438f5a.

puemos added 9 commits July 21, 2026 13:05
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
@puemos
puemos force-pushed the posthog-code/group-configure-settings branch from b46ec12 to c13b3b4 Compare July 21, 2026 13:21
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
@puemos
puemos force-pushed the posthog-code/group-configure-settings branch from f543a72 to 5a876ec Compare July 21, 2026 13:28
puemos added 2 commits July 21, 2026 15:46
Reverts 5a876ec.

Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
@puemos
puemos requested a review from k11kirky July 21, 2026 13:48
@puemos
puemos marked this pull request as ready for review July 21, 2026 13:48
"Environments",
EnvironmentsSettings,
),
agents: defineSettingsPage("Agents", AgentsSettings),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium: AI approval gate bypass

A signed-in organization member awaiting admin approval can open Settings, select Agents, and use “Run setup agent,” which calls taskService.createTask with workspaceMode: "cloud" and executionMode: "auto". Prevent this category and its agent actions from rendering in the pre-router settings dialog until AI data processing has been approved.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: the pre-router approval screen can open the shared Settings panel, and this PR newly exposes the Agents setup action there. This commit does not address that approval-state behavior, so I am leaving the thread open rather than marking a valid concern resolved.

@veria-ai

veria-ai Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR overview

This pull request groups task-related configuration into the Settings experience, including settings content for agent setup and task execution options. It adds or exposes UI paths such as the Agents settings area and setup-agent action from the settings page.

There is one open security concern: users who are signed in but still awaiting AI data-processing approval can reach the Agents settings flow and start an automatic cloud setup task. That creates a concrete approval-gate bypass for agent actions, though the impact appears limited to this pre-approval task execution path. No issues have been addressed yet, so the PR still needs a guard to hide or block these settings actions until approval is complete.

Open issues (1)

Fixed/addressed: 0 · PR risk: 6/10

@k11kirky k11kirky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — findings inline.

Comment thread packages/ui/src/features/sidebar/components/items/ConfigureItem.tsx
Comment thread packages/ui/src/features/sidebar/components/SidebarNavSection.tsx
Comment thread packages/ui/src/features/sidebar/components/SidebarNavSection.tsx
Comment thread packages/ui/src/features/settings/components/SettingsPanel.tsx Outdated
Comment thread packages/ui/src/features/settings/components/SettingsPanel.tsx
Generated-By: PostHog Code
Task-Id: 5579dbc2-d5dd-440f-8fb5-3cbd00ed0957
@puemos

puemos commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/trunk merge

@trunk-io
trunk-io Bot merged commit 944ac74 into main Jul 21, 2026
32 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/group-configure-settings branch July 21, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants