feat(data-warehouse): wire Intercom and HubSpot into the self-driving inbox#3614
Open
Gilbert09 wants to merge 1 commit into
Open
feat(data-warehouse): wire Intercom and HubSpot into the self-driving inbox#3614Gilbert09 wants to merge 1 commit into
Gilbert09 wants to merge 1 commit into
Conversation
… inbox Add Intercom and HubSpot as inbox source toggles. Both are OAuth sources, but that needs no bespoke UI: the generic DynamicSourceSetup renders their connect form's oauth field, and the generic integration flow starter (separate PR) launches the OAuth flow by kind. So this is the same one-registry-entry change as any credential source — two entries in EXTERNAL_INBOX_SOURCES plus the SourceProduct/analytics unions and icons.
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Intercom and HubSpot are the two OAuth-connected support sources deferred from the initial
30-source inbox batch (#3597). With the generic OAuth flow starter in place
(#3613), they can be wired in like any other source.
Changes
Two entries in the shared
EXTERNAL_INBOX_SOURCESregistry (setup: "dynamic"), plus thematching
SourceProduct/ToggleableSourceProduct,SignalSourceConfig.source_product, andanalytics-event unions, and their icon metadata. No bespoke setup form:
DynamicSourceSetuprenders each source's
oauthfield generically and the genericintegrationrouter starts theflow by
kind.How did you test this?
turbo typecheckfor@posthog/ui,@posthog/core,@posthog/shared,@posthog/api-client,@posthog/mobile— pass.pnpm --filter @posthog/shared build;biome checkon changed files — clean.Dependencies
tom/inbox-tier1-sources) for theEXTERNAL_INBOX_SOURCESregistry.source_productvalues ship in feat(data-warehouse): add Intercom and HubSpot as self-driving inbox sources posthog#72535 (merge before this toggles on).