Skip to content

refactor(mobile): reuse shared transport and permission logic#3635

Draft
richardsolomou wants to merge 5 commits into
posthog-code/share-mobile-inbox-transportfrom
posthog-code/share-mobile-mcp-skill-transport
Draft

refactor(mobile): reuse shared transport and permission logic#3635
richardsolomou wants to merge 5 commits into
posthog-code/share-mobile-inbox-transportfrom
posthog-code/share-mobile-mcp-skill-transport

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 21, 2026

Copy link
Copy Markdown
Member

Problem

Mobile maintains parallel MCP and skills transports, while desktop and mobile also make separate pending-prompt and permission-presentation decisions. These duplicate implementations can drift in endpoint behavior and user-visible task semantics.

Changes

Route mobile MCP marketplace, installation, OAuth, tool approval, and team-skill queries through the authenticated API client used by desktop, removing the duplicate transport modules.

Centralize pending-prompt retention, ordering, recovery selection, and key formatting in core. Share plan-content extraction plus permission classification, metadata, custom-input behavior, rejection selection, and initial approval choice across desktop and native renderers. Host-specific persistence and rendering remain separate.

How did you test this?

  • Core test suite (2,637 tests) and focused permission tests
  • Core and UI typechecks
  • Mobile test suite (338 tests) and focused plan-approval tests
  • Biome on changed files
  • Host-boundary check

The focused desktop PlanApprovalSelector test could not collect because the restored workspace is missing its existing tslib runtime dependency; the UI package typecheck passes.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit a5ab234.

Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared MCP and skill transport refactor(mobile): reuse shared transport and recovery logic Jul 21, 2026
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared transport and recovery logic refactor(mobile): reuse shared transport and presentation logic Jul 21, 2026
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared transport and presentation logic refactor(mobile): reuse shared transport and permission logic Jul 21, 2026
Generated-By: PostHog Code
Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant