refactor(mobile): reuse shared transport and permission logic#3635
Draft
richardsolomou wants to merge 5 commits into
Draft
Conversation
Generated-By: PostHog Code Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mobile maintains parallel MCP and skills transports, while desktop and mobile also make separate pending-prompt and permission-presentation decisions. These duplicate implementations can drift in endpoint behavior and user-visible task semantics.
Changes
Route mobile MCP marketplace, installation, OAuth, tool approval, and team-skill queries through the authenticated API client used by desktop, removing the duplicate transport modules.
Centralize pending-prompt retention, ordering, recovery selection, and key formatting in core. Share plan-content extraction plus permission classification, metadata, custom-input behavior, rejection selection, and initial approval choice across desktop and native renderers. Host-specific persistence and rendering remain separate.
How did you test this?
The focused desktop PlanApprovalSelector test could not collect because the restored workspace is missing its existing tslib runtime dependency; the UI package typecheck passes.
Automatic notifications
Created with PostHog Code