refactor(mobile): reuse inbox semantics#3641
Open
richardsolomou wants to merge 5 commits into
Open
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
richardsolomou
force-pushed
the
posthog-code/share-session-presentation-semantics
branch
from
July 23, 2026 13:12
436f795 to
52fcd91
Compare
richardsolomou
force-pushed
the
posthog-code/share-inbox-automation-presentation
branch
from
July 23, 2026 13:15
60ed26d to
a7d966c
Compare
richardsolomou
changed the title
richardsolomou
force-pushed
the
posthog-code/share-session-presentation-semantics
branch
from
July 23, 2026 13:40
52fcd91 to
dd741ed
Compare
richardsolomou
force-pushed
the
posthog-code/share-inbox-automation-presentation
branch
from
July 23, 2026 13:43
d966683 to
c326729
Compare
This was referenced Jul 23, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 23, 2026
richardsolomou
marked this pull request as ready for review
July 23, 2026 15:48
Contributor
|
Reviews (1): Last reviewed commit: "fix(core): require desktop inbox tab cou..." | Re-trigger Greptile |
richardsolomou
force-pushed
the
posthog-code/share-inbox-automation-presentation
branch
from
July 23, 2026 16:34
b409081 to
82384e6
Compare
richardsolomou
force-pushed
the
posthog-code/share-session-presentation-semantics
branch
2 times, most recently
from
July 23, 2026 17:28
9563ac8 to
9bc670c
Compare
richardsolomou
force-pushed
the
posthog-code/share-inbox-automation-presentation
branch
from
July 23, 2026 17:28
82384e6 to
637acc8
Compare
Generated-By: PostHog Code Task-Id: 40c57a59-b4e1-4760-8e56-ecd03e9c2f0f
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
Generated-By: PostHog Code Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
richardsolomou
force-pushed
the
posthog-code/share-inbox-automation-presentation
branch
from
July 23, 2026 18:55
637acc8 to
4a5f3c4
Compare
richardsolomou
force-pushed
the
posthog-code/share-session-presentation-semantics
branch
from
July 23, 2026 18:55
9bc670c to
6638011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mobile duplicated inbox-view analytics and report membership decisions already used by UI. Desktop and mobile analytics inputs have different valid shapes, so one optional-field contract could silently emit incorrect desktop counts.
Depends on #3640
Refs #2416
Changes
I switched mobile inbox consumers to the existing core engagement and membership policies. The analytics boundary uses discriminated desktop and mobile inputs, with desktop tab counts required and mobile defaults kept explicit. Platform-specific presentation remains in mobile.
How did you test this?
Automatic notifications
Created with PostHog Code