fix(updates): Keep bundle identity as PostHog Code#3679
Closed
charlesvien wants to merge 1 commit into
Closed
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
v0.58.0 shipped the #3557 rename with
productName/executableNamechanged to "PostHog". Squirrel.Mac names the installed bundle after the update payload and relaunches the pre-update bundle path, so every install that auto-updates gets moved to/Applications/PostHog.app, fails to relaunch, and leaves the old Dock pin pointing at a dead path.Changes
Minimal revert of the two identity fields to "PostHog Code", frozen with a comment the same way
appIdis, plus the handful of harness/docs paths that reference the built bundle. Display strings from #3557 are untouched. The next release's payload is namedPostHog Code.appagain, so v0.57.x installs update cleanly; the v0.58.0 cohort gets renamed back on their next update (one manual relaunch, same as they already hit).Follow-ups deliberately NOT in this PR: v0.58.0 should be pulled from the update feeds so v0.57.x stragglers stop updating into the broken state, and a proper display-only rename (CFBundleDisplayName) plus Dock-pin repair can come separately.
How did you test this?
tsc --noEmitand Biome clean on the touched files.Automatic notifications