feat(loops): Clean up the loop wizard#3739
Merged
Merged
Conversation
2 tasks
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/loops/components/LoopTriggerEditor.tsx:116-129
**Hand-Rolled Empty State**
The new no-trigger state recreates the shared empty-state layout with a centered `Flex`. The UI guide requires collection placeholders to use the Quill `Empty` components, so this state will miss shared accessibility and styling updates.
Reviews (1): Last reviewed commit: "clean up loops wizard" | Re-trigger Greptile |
|
😎 This pull request was merged. |
charlesvien
force-pushed
the
feat/loops-wizard-redesign
branch
from
July 23, 2026 06:26
7f8b1aa to
8d78a27
Compare
There was a problem hiding this comment.
Pure UI/UX rework of the loop wizard (styling, copy, a new trigger-type menu, size prop plumbing) with no schema, API, auth, billing, or CI surface touched; the sole reviewer comment about a hand-rolled empty state was addressed (the diff now uses Quill's Empty components) and shows resolved with a bot 👍.
- Author wrote 94% of the modified lines and has 19 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 723L, 12F substantive — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (723L, 12F, single-area, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 9001b17 · reviewed head 8d78a27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The create/edit loop wizard was cramped and confusing. Dropdowns were tiny, "Add trigger" always inserted a schedule you then had to re-type via a small select, trigger cards blended into the modal background, and the Context, Repository and Notifications sections didn't explain what they are, where output goes or how access works.
Changes
sizeprop onSettingsOptionSelectandTimezonePicker, plus wiring up the previously deadsizeprop onGitHubRepoPicker. Existing call sites keep the old size.How did you test this?
Drove the real Electron app over CDP through all four wizard steps: trigger type menu, all three card types, inline validation, empty state, and the channels toggle off/on hiding Context on both Options and Review. Ran
pnpm --filter @posthog/ui typecheck, Biome lint on changed files and the full@posthog/uiVitest suite (1977 passing).Automatic notifications