fix(loops): make detail page scroll and polish list rows#3743
Merged
Conversation
|
😎 This pull request was merged. |
Contributor
|
Reviews (1): Last reviewed commit: "restyle loop list rows to match template..." | Re-trigger Greptile |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
✅ Visual changes approved by @charlesvien — baseline updated in 4 changed. |
4 updated Run: 1e57b48d-dac7-4473-abcf-806bb652519e Co-authored-by: charlesvien <5378415+charlesvien@users.noreply.github.com>
There was a problem hiding this comment.
Contained UI polish (scroll container, spacing, row layout, show-more pagination) with matching snapshot updates and a bot-confirmed visual review; no risky territory touched and no outstanding concerns.
- Author wrote 27% of the modified lines and has 153 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 69L, 4F substantive — within ceiling |
| tier | ✓ | T1-agent / T1b-small (69L, 4F, two-areas, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ cc35bdc · reviewed head 824de8e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The loop detail page could not scroll: the root layout is overflow-hidden and the view never provided its own scroll container, so long loops (big instructions, run history) were clipped. The page also used a different content width than the list, the header actions were too small and the instructions textarea grew without bound. List rows showed a low-value trigger count and their colors did not match the template cards.
Changes
How did you test this?
Typecheck and Biome on @posthog/ui, plus visual iteration against the running dev app.
Automatic notifications